Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar customization for PNG #112

Closed

Conversation

let-aurn
Copy link

@let-aurn let-aurn commented Mar 30, 2020

πŸ”₯✨

Addressing Issue 111

  • Generate rounded radius
  • Add space between bars

πŸ€– 🀞

./audiowaveform -i ../path/to/audio.mp3 -o ../path/to/audio.png --end 211 -w 8000 -h 200 --no-axis-labels --background-color 00000000 --waveform-color EF5350FF --border-color 00000000

Output

image

❌ βœ‹

TODO:

  • Set the customizations as argument instead of hardcoding them
  • Fix: not whole waveform is generated (the incrementation is wrong)

- Generate rounded radius
- Add space between bars
@let-aurn let-aurn force-pushed the feature/bar-customization-for-png branch from ac0c6e3 to 7872387 Compare March 30, 2020 21:34
@chrisn
Copy link
Member

chrisn commented Apr 2, 2020

Thanks for contributing! If we were to add this feature, we'd need a few options:

  • waveform-style: normal / bars
  • bar-width
  • bar-gap
  • bar-style: square / rounded

@xDrJungle
Copy link

I know this is from a long time ago but would be a nice feature to add, a lot of websites and apps use this style now.

@YannickGagnon
Copy link
Contributor

Thanks for contributing! If we were to add this feature, we'd need a few options:

  • waveform-style: normal / bars
  • bar-width
  • bar-gap
  • bar-style: square / rounded

Hi @chrisn, I'd be keen to take over this PR and make it happen.
Appart from the said missing options and perhaps the "Fix: not whole waveform is generated (the incrementation is wrong)"

Is there anything else I should worry about?

Thanks

@chrisn
Copy link
Member

chrisn commented May 28, 2023

See #187

@chrisn chrisn closed this May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants