Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: creating initial tests setup #18

Merged
merged 11 commits into from
Sep 29, 2024
Merged

chore: creating initial tests setup #18

merged 11 commits into from
Sep 29, 2024

Conversation

nicholasgriffintn
Copy link
Member

@nicholasgriffintn nicholasgriffintn commented Mar 30, 2024

Description:

Adds tests against the codebase, should improve coverage to all areas of the codebase, but only covers unit testing.

I've had a few errors here and clearly never really got back to this, I've decided to just skip stuff to get something in at least.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:

We don't have tests at the moment

Code changes:

  • Installs new dependencies for running tests
  • Adds missing options that were discovered during test creation
  • Updates tests

Copy link

codeclimate bot commented Mar 30, 2024

Code Climate has analyzed commit 4182b71 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 90.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 72.6% (2.6% change).

View more on Code Climate.

test/unit/consumer.test.ts Fixed Show fixed Hide fixed
test/unit/consumer.test-todo.ts Fixed Show fixed Hide fixed
test/unit/consumer.test.ts Dismissed Show dismissed Hide dismissed
@michaelwittig michaelwittig mentioned this pull request Jun 27, 2024
9 tasks
@nicholasgriffintn nicholasgriffintn changed the title WIP: creating tests chore: creating initial tests setup Sep 29, 2024
@nicholasgriffintn nicholasgriffintn merged commit f42f471 into main Sep 29, 2024
3 of 7 checks passed
@nicholasgriffintn nicholasgriffintn deleted the testing branch September 29, 2024 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant