Added strict check for eslint warnings in GitHub Actions builds

bbc · Jul 15, 2023 · d1738f2 · d1738f2
1 parent fb2d015
commit d1738f2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -1,5 +1,7 @@
-# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
-# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
+# This workflow will do a clean install of node dependencies, build the source
+# code and run tests across different versions of node. For more information
+# see:
+# https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
 
 name: Node.js CI
 
@@ -28,5 +30,6 @@ jobs:
       with:
         node-version: ${{ matrix.node-version }}
     - run: npm ci
-    - run: npm run build --if-present
+    - run: npm run lint -- --max-warnings=0
+    - run: npm run build
     - run: npm run test -- --browsers=${{ matrix.browser }}
diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml
@@ -1,5 +1,6 @@
-# This workflow will run tests using node and then publish a package to NPM when a release is created
-# For more information see: https://help.github.com/actions/language-and-framework-guides/publishing-nodejs-packages
+# This workflow will run tests using node and then publish a package to NPM
+# when a release is created. For more information see:
+# https://help.github.com/actions/language-and-framework-guides/publishing-nodejs-packages
 
 name: Node.js Package
 
@@ -23,6 +24,7 @@ jobs:
         with:
           node-version: 16.x
       - run: npm ci
+      - run: npm run lint -- --max-warnings=0
       - run: npm run test -- --browsers=${{ matrix.browser }}
 
   publish-npm: