Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_float timestamp methods and further support to negative timestamps #86

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

philipnbbc
Copy link
Contributor

@philipnbbc philipnbbc commented Mar 15, 2024

Details

This PR

  • adds Timestamp.to_float and Timestamp.to_unix_float methods
  • removes deprecated Timestamp.to_utc
  • Changed Timestamp.to_unix to return the sign as well in the tuple result
  • supports conversion between negative Timestamp and datetime and iso8601
  • fixes Timestamp.from_unix when is_leap is True

Pivotal Story

Story URL: https://www.pivotaltracker.com/story/show/187046592

Related PRs

Where appropriate. Indicate order to be merged.

Links to external test runs/working deployment

Where appropriate, if separate to default CI run

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • New features and API breaks are flagged in commit messages using magic strings
  • Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
  • Downstream repos have been checked for potential breaks & fixed as needed
  • APIs/UIs/CLIs updated as required
  • PR added to Pivotal story
  • Follow-up stories added to Pivotal
  • Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
  • Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on Cloudfit PRs

Removed the to_utc method which was deprecated in favour of to_unix.
CHanged to_unix to return the sign as well.

sem-ver: api-break
@philipnbbc philipnbbc requested a review from a team as a code owner March 15, 2024 12:11
@samdbmg samdbmg self-assigned this Mar 21, 2024
Copy link
Member

@samdbmg samdbmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipnbbc philipnbbc merged commit 009c761 into main Mar 21, 2024
6 checks passed
@philipnbbc philipnbbc deleted the philipn-float-timestamps branch March 21, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants