Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe flow segment timing adjustments when GETting #11

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

philipnbbc
Copy link
Contributor

Details

This PR adds an explanation to /segments GET for timing and range adjustments. It also includes a naming consistency change to use sample rather than media_unit for audio samples, video frames or data units. This also better aligns it with the property names.

Pivotal Story

Story URL: https://www.pivotaltracker.com/story/show/186711089

Related PRs

Where appropriate. Indicate order to be merged.

Links to external test runs/working deployment

Where appropriate, if separate to default CI run

Submitter PR Checks

(tick as appropriate)

  • Added bbc/rd-apmm-cloudfit team as a reviewer
  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • New features and API breaks are flagged in commit messages using magic strings
  • Repo maintainer is notified that a release is required
  • Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
  • Downstream repos have been checked for potential breaks & fixed as needed
  • APIs/UIs/CLIs updated as required
  • PR added to Pivotal story
  • Follow-up stories added to Pivotal
  • Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
  • Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on Cloudfit PRs

@philipnbbc philipnbbc requested a review from a team January 4, 2024 10:06
@samdbmg samdbmg self-assigned this Jan 4, 2024
Copy link
Member

@samdbmg samdbmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

api/TimeAddressableMediaStore.yaml Outdated Show resolved Hide resolved
Co-authored-by: Sam Mesterton-Gibbons <sam.mesterton-gibbons@bbc.co.uk>
@philipnbbc philipnbbc merged commit d384c1a into main Jan 4, 2024
3 checks passed
@philipnbbc philipnbbc deleted the philipn-flow-segment-get-adjustments branch January 4, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants