Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI pipeline #2

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Improve CI pipeline #2

merged 3 commits into from
Sep 14, 2023

Conversation

samdbmg
Copy link
Member

@samdbmg samdbmg commented Sep 14, 2023

Details

Updates CI pipeline to only upload docs if there's been a change since the last successful build. Also reduces the CI frequency to run once a week, rather than every day

Pivotal Story

Story URL: https://www.pivotaltracker.com/story/show/185968237

Related PRs

Follows #1

Links to external test runs/working deployment

Added a pair of dummy commits in https://github.com/bbc/tams/actions/runs/6183653974 to prove it works

Submitter PR Checks

(tick as appropriate)

  • Added bbc/rd-apmm-cloudfit team as a reviewer
  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • New features and API breaks are flagged in commit messages using magic strings
  • Repo maintainer is notified that a release is required
  • Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
  • Downstream repos have been checked for potential breaks & fixed as needed
  • APIs/UIs/CLIs updated as required
  • PR added to Pivotal story
  • Follow-up stories added to Pivotal
  • Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
  • Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on Cloudfit PRs

Updates CI pipeline to only upload documentation if there's been a
change since the last successful build.
@samdbmg samdbmg requested a review from a team September 14, 2023 10:27
Copy link
Contributor

@philipnbbc philipnbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question inline but LGTM either way.

.github/workflows/ci-workflow.yml Show resolved Hide resolved
Copy link
Contributor

@j616 j616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion for a tweak to triggers

.github/workflows/ci-workflow.yml Show resolved Hide resolved
Co-authored-by: James Sandford <james.sandford@bbc.co.uk>
Base automatically changed from sammg-add-api to main September 14, 2023 19:35
@samdbmg samdbmg merged commit 36df254 into main Sep 14, 2023
2 checks passed
@samdbmg samdbmg deleted the sammg-improve-ci branch September 14, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants