Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow negative flow timeranges #5

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

philipnbbc
Copy link
Contributor

@philipnbbc philipnbbc commented Oct 10, 2023

Details

This PR changes the JSON schema pattern for the timerange property returned with a flow to allow negative timestamps. E.g. if a video flow has presentation origin at 0 but with pre-charge.

Pivotal Story

Story URL: https://www.pivotaltracker.com/story/show/186121500

Related PRs

Where appropriate. Indicate order to be merged.

Links to external test runs/working deployment

Where appropriate, if separate to default CI run

Submitter PR Checks

(tick as appropriate)

  • Added bbc/rd-apmm-cloudfit team as a reviewer
  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • New features and API breaks are flagged in commit messages using magic strings
  • Repo maintainer is notified that a release is required
  • Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
  • Downstream repos have been checked for potential breaks & fixed as needed
  • APIs/UIs/CLIs updated as required
  • PR added to Pivotal story
  • Follow-up stories added to Pivotal
  • Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
  • Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on Cloudfit PRs

E.g. flows with precharge.
@philipnbbc philipnbbc requested a review from a team October 10, 2023 15:22
@j616 j616 self-assigned this Oct 10, 2023
Copy link
Contributor

@j616 j616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipnbbc philipnbbc merged commit fd70174 into main Oct 10, 2023
2 checks passed
@philipnbbc philipnbbc deleted the philipn-negative-flow-timeranges branch October 10, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants