Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supporting documentation index #73

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Add supporting documentation index #73

merged 2 commits into from
Jul 9, 2024

Conversation

j616
Copy link
Contributor

@j616 j616 commented Jul 9, 2024

Details

  • Add supporting documentation index
  • Fix warning regarding inconsistent case on FROM ... AS ... in dockerfile

Pivotal Story (if relevant)

Story URL:

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@j616 j616 marked this pull request as ready for review July 9, 2024 13:46
@j616 j616 requested a review from a team as a code owner July 9, 2024 13:46
AndrewGibb
AndrewGibb approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@AndrewGibb AndrewGibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j616 j616 merged commit 27ff1eb into main Jul 9, 2024
5 checks passed
@j616 j616 deleted the jamessa-docsIndex branch July 9, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGibb AndrewGibb AndrewGibb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j616 @AndrewGibb