Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add words to flow segment POSTs related to overlaps #76

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

philipnbbc
Copy link
Contributor

Details

Clients should not POST a flow segment that overlaps with existing segments. This includes segments with equal timerange where the second POST can be viewed as a modification.

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/187885844

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

Clients should not POST a flow segment that overlaps with existing
segments. This includes segments with equal timerange where the
second POST can be viewed as a modification.
@philipnbbc philipnbbc requested a review from a team as a code owner July 22, 2024 11:33
Copy link
Contributor

@AndrewGibb AndrewGibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipnbbc philipnbbc merged commit 0681e36 into main Jul 23, 2024
5 checks passed
@philipnbbc philipnbbc deleted the philipn-modify-segment-undefined-behaviour branch July 23, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants