Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter 'lineOffset': offset line to the left or right. #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

plepe
Copy link

@plepe plepe commented May 2, 2020

This parameter offsets a line to the left or the right.

@plepe
Copy link
Author

plepe commented May 3, 2020

After I pushed the pull request, I noticed that there's already a similar pull request: #57.

Pull request #57 solves this problem quite differently, it will first offset the line and then calculate the position, whereas my pull request calculates the positions and then offsets the symbols. You can notice the difference with these screenshots:

With lineOffset -15 (blue) resp. 15 (red):
lineOffset

With symbolOffset -15 (blue) resp. 15 (red):
symbolOffset

I think both variants are interesting. I would exchange the parameter names though, because in my pull request the symbols are offset (so symbolOffset would make sense) and in #57 the lines are offset (lineOffset). What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant