fixed deadlock in json-rpc mode

* properly unlock mutex to avoid deadlock see #572
bbernhard · Aug 9, 2024 · e6ff51e · e6ff51e
1 parent f328939
commit e6ff51e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/api/api.go b/src/api/api.go
@@ -531,10 +531,11 @@ func (a *Api) wsPing(ws *websocket.Conn, stop chan struct{}) {
 			return
 		case <-pingTicker.C:
 			a.wsMutex.Lock()
-			defer a.wsMutex.Unlock()
 			if err := ws.WriteMessage(websocket.PingMessage, []byte{}); err != nil {
+				a.wsMutex.Unlock()
 				return
 			}
+			a.wsMutex.Unlock()
 		}
 	}
 }

diff --git a/src/client/jsonrpc2.go b/src/client/jsonrpc2.go
@@ -229,14 +229,14 @@ func (r *JsonRpc2Client) GetReceiveChannel() (chan JsonRpc2ReceivedMessage, stri
 	}
 
 	r.receivedMessagesMutex.Lock()
-	defer r.receivedMessagesMutex.Unlock()
 	r.receivedMessagesChannels[channelUuid.String()] = c
+	r.receivedMessagesMutex.Unlock()
 
 	return c, channelUuid.String(), nil
 }
 
 func (r *JsonRpc2Client) RemoveReceiveChannel(channelUuid string) {
 	r.receivedMessagesMutex.Lock()
-	defer r.receivedMessagesMutex.Unlock()
 	delete(r.receivedMessagesChannels, channelUuid)
+	r.receivedMessagesMutex.Unlock()
 }