Merge pull request #30 from bboyle/hidden-polyfill

fix detection of `@hidden` support

bower.json

@@ -1,7 +1,7 @@
 {
   "name": "relevance",
   "description": "Progressive disclosure (relevance) for HTML elements",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "homepage": "https://github.com/bboyle/relevance",
   "authors": [
     "Ben Boyle <benjamins.boyle@gmail.com>"

package.json

@@ -2,7 +2,7 @@
   "name": "relevance",
   "title": "relevance",
   "description": "Progressive disclosure (relevance) for HTML elements",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "homepage": "https://github.com/bboyle/relevance",
   "author": {
     "name": "Ben Boyle",

src/relevance.js

@@ -8,9 +8,9 @@ if ( jQuery !== 'undefined' ) {
 			elementsToDisable = 'button, input, select, textarea',
 			polyfillHidden = (function() {
 				var hidden = $( '<div hidden></div>' );
-				var isHidden = hidden.appendTo( 'body' ).is( ':visible' );
+				var hiddenSupported = hidden.appendTo( 'body' ).is( ':hidden' );
 				hidden.remove();
-				return ! isHidden;
+				return ! hiddenSupported;
 			}()),
 
 			formElementsByName = function( form, name ) {
@@ -97,9 +97,9 @@ if ( jQuery !== 'undefined' ) {
 			relevant: function( makeRelevant ) {
 				var targets;
 				if ( makeRelevant ) {
-					targets = this.filter( '[hidden]' ).trigger( relevantEvent );
+					targets = this.filter( ':hidden' ).trigger( relevantEvent );
 				} else {
-					targets = this.not( '[hidden]' ).trigger( irrelevantEvent );
+					targets = this.not( ':hidden' ).trigger( irrelevantEvent );
 				}
 				if ( targets.length ) {
 					recalculateDependents.call( targets, makeRelevant );

test/events.html

@@ -26,6 +26,13 @@
 			color: #111;
 		}
 
+		[hidden] {
+			display: none;
+		}
+		input {
+			_display: expression(this.hidden?'none':'block');
+		}
+
 		#qunit-fixture {
 			position: static;
 		}

test/events.js

@@ -42,33 +42,48 @@
 
 	});
 
+
 	test( 'relevant event bubbles', 3, function() {
 
-		$( '#bar' ).parent().bind( 'relevant', function() {
+		$( '#bar' ).parent().bind( 'relevant.test', function() {
 			ok( true, 'relevant event detected on #bar parent with .bind()' );
 		});
-		$( 'body' ).bind( 'relevant', function() {
+		$( 'body' ).bind( 'relevant.test', function() {
 			ok( true, 'relevant event detected with body.bind()' );
 		});
-		$( document ).bind( 'relevant', function() {
+		$( document ).bind( 'relevant.test', function() {
 			ok( true, 'relevant event detected with document.bind()' );
 		});
 
 		$( '#bar' ).relevance( 'relevant', true );
 
-		$( '#foo, body' ).unbind( 'relevant.test' );
+		$( '#bar, body' ).unbind( 'relevant.test' );
 		$( document ).unbind( 'relevant.test' );
 
 	});
 
 
+	test( 'relevant event triggered when nested', 1, function() {
+		var eventDetected = 0;
+		$( '#foo' ).bind( 'relevant.test', function() {
+			eventDetected += 1;
+			strictEqual( eventDetected, 1, 'relevant event detected for nested element' );
+		});
+
+		$( '#foo' ).closest( '.group' ).relevance( 'relevant', false );
+		$( '#foo' ).relevance( 'relevant', true );
+
+		$( '#foo' ).unbind( 'relevant.test' );
+	});
+
+
 	module( 'irrelevant events' );
 
 	test( 'irrelevant event is triggered for visible elements', 1, function() {
 
 		var eventDetected = 0;
 
-		$( '#foo' ).bind( 'irrelevant', function() {
+		$( '#foo' ).bind( 'irrelevant.test', function() {
 			eventDetected += 1;
 			strictEqual( eventDetected, 1, 'irrelevant event detected' );
 		});
@@ -77,16 +92,18 @@
 		// should not fire event now element is irrelevant
 		$( '#foo' ).relevance( 'relevant', false );
 
+		$( '#foo' ).unbind( 'irrelevant.test' );
 	});
 
 	test( 'irrelevant event not triggered for hidden elements', 0, function() {
 
-		$( '#bar' ).bind( 'irrelevant', function() {
+		$( '#bar' ).bind( 'irrelevant.test', function() {
 			ok( true, 'irrelevant event detected' );
 		});
 
 		$( '#bar' ).relevance( 'relevant', false );
 
+		$( '#bar' ).unbind( 'irrelevant.test' );
 	});
 
 	test( 'irrelevant event bubbles', 3, function() {