chore: treat file as binary, proper disable upload

bcgov · Sep 25, 2024 · 64d6ae6 · 64d6ae6
1 parent cc6c676
commit 64d6ae6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/app/backend/lib/s3upload.ts b/app/backend/lib/s3upload.ts
@@ -29,7 +29,6 @@ s3upload.post('/api/s3/upload', limiter, async (req, res) => {
     return res.status(404).end();
   }
   const form = formidable(commonFormidableConfig);
-
   const files = await parseForm(form, req).catch((err) => {
     return res.status(400).json({ error: err }).end();
   });
@@ -42,7 +41,7 @@ s3upload.post('/api/s3/upload', limiter, async (req, res) => {
   if (!uploaded) {
     return res.status(200).end();
   }
-  const file = fs.readFileSync(uploaded.filepath, 'utf8');
+  const file = fs.readFileSync(uploaded.filepath);
 
   const params = {
     Bucket: AWS_S3_BUCKET,
@@ -51,7 +50,6 @@ s3upload.post('/api/s3/upload', limiter, async (req, res) => {
   };
 
   const uploadResult = await uploadFileToS3(params);
-
   if (uploadResult) {
     return res.json({ status: 'success' });
   }

diff --git a/app/pages/analyst/gis/coverages.tsx b/app/pages/analyst/gis/coverages.tsx
@@ -95,7 +95,6 @@ const CoveragesTab = () => {
   const [selectedFile, setSelectedFile] = useState<File>();
   const [isUploading, setIsUploading] = useState(false);
   const [uploadSuccess, setUploadSuccess] = useState(false);
-
   const fileComponentValue = [
     {
       id: '',
@@ -183,7 +182,7 @@ const CoveragesTab = () => {
           <ButtonLink
             onClick={handleUpload}
             href="#"
-            disabled={isUploading || selectedFile === null}
+            disabled={isUploading || !selectedFile}
           >
             {isUploading ? 'Uploading' : 'Upload'}
           </ButtonLink>