Skip to content

Commit

Permalink
Merge pull request #3490 from bcgov/NDT-303-Update-Text-in-Budget-Det…
Browse files Browse the repository at this point in the history
…ails-and-Benefits-Accordion-on-Application-page

chore: update budget and benefit title on application
  • Loading branch information
rafasdc authored Aug 22, 2024
2 parents 0b71fa8 + a6ca59b commit 7de8899
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 6 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## [1.182.1](https://github.com/bcgov/CONN-CCBC-portal/compare/v1.182.0...v1.182.1) (2024-08-22)

# [1.182.0](https://github.com/bcgov/CONN-CCBC-portal/compare/v1.181.2...v1.182.0) (2024-08-22)

### Features
Expand Down
4 changes: 2 additions & 2 deletions app/formSchema/pages/benefits.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ const benefits: Record<string, RJSFSchema> = {
},
numberOfHouseholds: {
title:
'Final number of Eligible Households targeted by this proposal. This value should match cell F151 in Template 1 – Eligibility Summary.',
'Final number of Eligible Households targeted by this proposal is auto-filled from Template 1 cell F151 in the Eligibility Summary, including all related RFIs.',
type: 'number',
maximum: 100000,
},
householdsImpactedIndigenous: {
title:
'Number of households on Indigenous lands impacted by this proposal. This value should match cell G55 in Template 1 – Eligibility Summary.',
'Number of households on Indigenous lands impacted by this proposal is auto-filled from Template 1 cell G55 in the Eligibility Summary, including all related RFIs.',
type: 'number',
maximum: 100000,
},
Expand Down
5 changes: 3 additions & 2 deletions app/formSchema/pages/budgetDetails.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ const budgetDetails: Record<string, RJSFSchema> = {
totalEligibleCosts: {
title: `The Applicant must complete and upload the appropriate templates related to the Project Budget details in the Template Uploads section. Values here must match values in Template 2 - Detailed Budget.
Total eligible costs (Template 2 - cell H27)`,
Total eligible costs is auto-filled from Template 2 - cell H27 in the Detailed Budget, including all related RFIs.`,
type: 'number',
},
totalProjectCost: {
title: 'Total project cost (Template 2 - cell H28)',
title:
'Total project costs is auto-filled from Template 2 - cell H28 in the Detailed Budget, including all related RFIs.',
type: 'number',
},
},
Expand Down
4 changes: 3 additions & 1 deletion app/tests/components/Review/ReviewTheme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,9 @@ const sharedReviewThemeTests = (renderTest) => {
);

const errorCell = section
.getByText('Total project cost (Template 2 - cell H28)')
.getByText(
'Total project costs is auto-filled from Template 2 - cell H28 in the Detailed Budget, including all related RFIs.'
)
.closest('tr')
.getElementsByTagName('td')[0];

Expand Down
1 change: 1 addition & 0 deletions db/sqitch.plan
Original file line number Diff line number Diff line change
Expand Up @@ -639,3 +639,4 @@ tables/cbc_add_fk_update_constraint 2024-07-11T20:32:11Z Rafael Solorzano <61289
@1.181.1 2024-08-22T14:38:05Z CCBC Service Account <ccbc@button.is> # release v1.181.1
@1.181.2 2024-08-22T16:09:35Z CCBC Service Account <ccbc@button.is> # release v1.181.2
@1.182.0 2024-08-22T16:48:01Z CCBC Service Account <ccbc@button.is> # release v1.182.0
@1.182.1 2024-08-22T17:30:53Z CCBC Service Account <ccbc@button.is> # release v1.182.1
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "CONN-CCBC-portal",
"version": "1.182.0",
"version": "1.182.1",
"main": "index.js",
"repository": "https://github.com/bcgov/CONN-CCBC-portal.git",
"author": "Romer, Meherzad CITZ:EX <Meherzad.Romer@gov.bc.ca>",
Expand Down

0 comments on commit 7de8899

Please sign in to comment.