Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create cbc admin role #3301

Merged
merged 6 commits into from
Jun 3, 2024
Merged

feat: create cbc admin role #3301

merged 6 commits into from
Jun 3, 2024

Conversation

AntBush
Copy link
Contributor

@AntBush AntBush commented May 23, 2024 •
edited by jira bot
Loading

Implements NDT-312

  • Check to trigger automatic release process

@AntBush AntBush force-pushed the NDT-312-create-cbc-admin-role-for-editing-cbc-data branch from 13e6f3c to 0236fb1 Compare May 23, 2024 18:05
github-advanced-security[bot]
github-advanced-security bot found potential problems May 23, 2024
View reviewed changes
app/utils/getAuthRole.ts Fixed Show fixed Hide fixed
@AntBush AntBush force-pushed the NDT-312-create-cbc-admin-role-for-editing-cbc-data branch from 1c4489f to c65706d Compare May 23, 2024 19:14
@AntBush AntBush marked this pull request as ready for review May 23, 2024 19:14
rafasdc
rafasdc reviewed May 30, 2024
View reviewed changes
db/verify/tables/cbc_data_001.sql Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this file for cleanliness, otherwise looks good!

@AntBush AntBush force-pushed the NDT-312-create-cbc-admin-role-for-editing-cbc-data branch from f1db79a to 23dfdd9 Compare May 31, 2024 15:47
@AntBush AntBush force-pushed the NDT-312-create-cbc-admin-role-for-editing-cbc-data branch from 23dfdd9 to 1e8dccd Compare May 31, 2024 16:02
@rafasdc rafasdc self-requested a review May 31, 2024 16:02
@AntBush AntBush enabled auto-merge May 31, 2024 16:03
@AntBush AntBush force-pushed the NDT-312-create-cbc-admin-role-for-editing-cbc-data branch from 1e8dccd to 8fb1fdb Compare June 3, 2024 13:32
@AntBush AntBush merged commit 1718619 into main Jun 3, 2024
40 of 42 checks passed
@AntBush AntBush deleted the NDT-312-create-cbc-admin-role-for-editing-cbc-data branch June 3, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafasdc rafasdc rafasdc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntBush @rafasdc