fix: feature db name to match release name #3380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafasdc
force-pushed
the
fix-feature-db-match-release-name
branch
from
3bd2e45
to
2cc62df
Compare
AntBush
reviewed
Jun 24, 2024
| @@ -62,6 +62,8 @@ jobs: | |||
| openshift_token: ${{ secrets.OPENSHIFT_TOKEN }} | |||
| - name: Setup database | |||
| run: | | |||
| FEATURE_NAME_LOWER=$(echo $FEATURE_NAME | tr '[:upper:]' '[:lower:]') | |||
| FEATURE_NAME_LOWER_SHORT=$(echo $FEATURE_NAME_LOWER | cut -c -30) | |||
There was a problem hiding this comment.
Aren't we missing the sed 's/-*$//' command here?
Suggested change
| FEATURE_NAME_LOWER_SHORT=$(echo $FEATURE_NAME_LOWER | cut -c -30) | |
| FEATURE_NAME_LOWER_SHORT=$(echo $FEATURE_NAME_LOWER | cut -c -30 | sed 's/-*$//') |
| @@ -62,6 +62,8 @@ jobs: | |||
| openshift_token: ${{ secrets.OPENSHIFT_TOKEN }} | |||
| - name: Setup database | |||
| run: | | |||
| FEATURE_NAME_LOWER=$(echo $FEATURE_NAME | tr '[:upper:]' '[:lower:]') | |||
| FEATURE_NAME_LOWER_SHORT=$(echo $FEATURE_NAME_LOWER | cut -c -30) | |||
| chmod +x ./lib/feature_envs/create_feature_db.sh | |||
| ./lib/feature_envs/create_feature_db.sh ccbc ${{ env.FEATURE_NAME }} ${{ secrets.OPENSHIFT_APP_NAMESPACE }} | |||
There was a problem hiding this comment.
I think we're supposed to pass the FEATURE_NAME_LOWER_SHORT here right?
Suggested change
| ./lib/feature_envs/create_feature_db.sh ccbc ${{ env.FEATURE_NAME }} ${{ secrets.OPENSHIFT_APP_NAMESPACE }} | |
| ./lib/feature_envs/create_feature_db.sh ccbc "$FEATURE_NAME_LOWER_SHORT" ${{ secrets.OPENSHIFT_APP_NAMESPACE }} |
AntBush
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements [NDT-]