DBC22-2465: fixed cam and event list pages updating read count

bcgov · Sep 4, 2024 · 160c1dc · 160c1dc
1 parent e051855
commit 160c1dc
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/src/frontend/src/Components/map/panels/AdvisoriesPanel.js b/src/frontend/src/Components/map/panels/AdvisoriesPanel.js
@@ -15,12 +15,17 @@ import AdvisoriesList from '../../advisories/AdvisoriesList';
 import './AdvisoriesPanel.scss';
 
 export default function AdvisoriesPanel(props) {
-  const { advisories } = props;
+  const { advisories, openAdvisoriesOverlay } = props;
 
   // Context
   const { cmsContext, setCMSContext } = useContext(CMSContext);
 
   useEffect(() => {
+    // Do not update context if the overlay is not open
+    if (openAdvisoriesOverlay === false) {
+      return;
+    }
+
     const advisoriesIds = advisories.map(advisory => advisory.id);
 
     // Combine and remove duplicates
@@ -29,7 +34,7 @@ export default function AdvisoriesPanel(props) {
 
     setCMSContext(updatedContext);
     localStorage.setItem('cmsContext', JSON.stringify(updatedContext));
-  }, [advisories]);
+  }, [advisories, openAdvisoriesOverlay]);
 
   return (
     <div className="popup popup--advisories" tabIndex={0}>

diff --git a/src/frontend/src/pages/CamerasListPage.js b/src/frontend/src/pages/CamerasListPage.js
@@ -345,7 +345,7 @@ export default function CamerasListPage() {
             onClick={() => setOpenAdvisoriesOverlay(!openAdvisoriesOverlay)}>
             <FontAwesomeIcon icon={faXmark} />
           </button>
-          <AdvisoriesPanel advisories={advisories} />
+          <AdvisoriesPanel advisories={advisories} openAdvisoriesOverlay={openAdvisoriesOverlay} />
         </div>
       }
 

diff --git a/src/frontend/src/pages/EventsListPage.js b/src/frontend/src/pages/EventsListPage.js
@@ -446,7 +446,7 @@ export default function EventsListPage() {
             onClick={() => setOpenAdvisoriesOverlay(!openAdvisoriesOverlay)}>
             <FontAwesomeIcon icon={faXmark} />
           </button>
-          <AdvisoriesPanel advisories={advisories} />
+          <AdvisoriesPanel advisories={advisories} openAdvisoriesOverlay={openAdvisoriesOverlay} />
         </div>
       }