Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBC22-1836: added onKeyDown for visible non-interactive elements #308

Merged
merged 1 commit into from
Mar 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/frontend/src/Components/FriendlyTime.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,15 @@ export default function FriendlyTime( {date} ) {
title={dateFormatted}
onClick={(event) => {
event.stopPropagation();
setShowTooltip(!showTooltip)}
}>
setShowTooltip(!showTooltip);
}}
onKeyDown={(keyEvent) => {
if (keyEvent.keyCode == 13) {
event.stopPropagation();
setShowTooltip(!showTooltip)
}
}}>

<p className="friendly-time-text">
<ReactTimeAgo date={date} locale="en-US"/>
</p>
Expand Down
6 changes: 5 additions & 1 deletion src/frontend/src/Components/Map.js
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,11 @@ export default function MapWrapper({
ref={panel} className={`side-panel ${openPanel ? 'open' : ''}`}
onClick={maximizePanel}
onTouchMove={maximizePanel}
>
onKeyDown={(keyEvent) => {
if (keyEvent.keyCode == 13) {
maximizePanel();
}
}}>

<button
className="close-panel"
Expand Down
8 changes: 7 additions & 1 deletion src/frontend/src/Components/advisories/AdvisoriesList.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@ export default function Advisories(props) {
<ul className="advisories-list">
{!!advisories && advisories.map((advisory, index) => {
return (
<li className="advisory-li unread" key={advisory.id} onClick={() => handleClick(advisory)}>
<li className="advisory-li unread" key={advisory.id} onClick={() => handleClick(advisory)}
onKeyDown={(keyEvent) => {
if (keyEvent.keyCode == 13) {
handleClick(advisory);
}
}}>

<div className="advisory-li-title-container">
<h4 className='advisory-li-title'>{advisory.title}</h4>
{showTimestamp &&
Expand Down
7 changes: 6 additions & 1 deletion src/frontend/src/Components/bulletins/BulletinsList.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ export default function Bulletins(props) {
<ul className='bulletins-list'>
{!!bulletins && bulletins.map((bulletin, index) => {
return (
<li className='bulletin-li unread' key={bulletin.id} onClick={() => handleClick(bulletin)}>
<li className='bulletin-li unread' key={bulletin.id} onClick={() => handleClick(bulletin)}
onKeyDown={(keyEvent) => {
if (keyEvent.keyCode == 13) {
handleClick(bulletin);
}
}}>

<div className='bulletin-li-title-container'>
<h3 className='bulletin-li-title'>{bulletin.title}</h3>
Expand Down
16 changes: 14 additions & 2 deletions src/frontend/src/Components/cameras/CameraCard.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,13 @@ export default function CameraCard(props) {
<p>Unable to retrieve latest image. Showing last image received.</p>
<FontAwesomeIcon icon={faXmark} onClick={handleChildClick} />
</div>
<div className={'card-pill' + (show ? ' bounce' : ' hidden') } onClick={handleChildClick} >
<div className={'card-pill' + (show ? ' bounce' : ' hidden') } onClick={handleChildClick}
onKeyDown={(keyEvent) => {
if (keyEvent.keyCode == 13) {
handleChildClick();
}
}}>

<p>Stale</p>
<FontAwesomeIcon icon={faCircleInfo} />
</div>
Expand All @@ -96,7 +102,13 @@ export default function CameraCard(props) {
<p>Longer than expected delay, displaying last image received.</p>
<FontAwesomeIcon icon={faXmark} onClick={handleChildClick} />
</div>
<div className={'card-pill' + (show ? ' bounce' : ' hidden') } onClick={handleChildClick} >
<div className={'card-pill' + (show ? ' bounce' : ' hidden') } onClick={handleChildClick}
onKeyDown={(keyEvent) => {
if (keyEvent.keyCode == 13) {
handleChildClick();
}
}}>

<p>Delayed</p>
<FontAwesomeIcon icon={faCircleInfo} />
</div>
Expand Down
16 changes: 8 additions & 8 deletions src/frontend/src/Components/events/EventsTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -150,14 +150,14 @@ export default function EventsTable(props) {
return (
<th className={header.id} key={header.id} colSpan={header.colSpan}>
{!header.isPlaceholder && !showLoader && (
<span
{...{
className: header.column.getCanSort() ?
'cursor-pointer select-none' :
'',
onClick: () => toggleSortingHandler(header.column),
}}
>
<span className={ header.column.getCanSort() ? 'cursor-pointer select-none' : '' }
onClick={() => toggleSortingHandler(header.column)}
onKeyDown={(keyEvent) => {
if (keyEvent.keyCode == 13) {
toggleSortingHandler(header.column);
}
}}>

{flexRender(
header.column.columnDef.header,
header.getContext()
Expand Down
11 changes: 10 additions & 1 deletion src/frontend/src/Components/map/camPopup.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,16 @@ export default function CamPopup(props) {
{camera &&
<div className="popup__content">
<div className="popup__content__title">
<p className="name" onClick={handlePopupClick}>{camera.name}</p>
<p className="name"
onClick={handlePopupClick}
onKeyDown={(keyEvent) => {
if (keyEvent.keyCode == 13) {
handlePopupClick();
}
}}>

{camera.name}
</p>
</div>
{camera.is_on ?
<div className="popup__content__image">
Expand Down
11 changes: 9 additions & 2 deletions src/frontend/src/pages/CameraDetailsPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ export default function CameraDetailsPage() {

const play = () => {
// Pre load images for preventing strobing
// For Firefox, Settings Performance > Use recommended performance settings
// For Firefox, Settings Performance > Use recommended performance settings
// and Performance > Use recommended performance settings > Use hardware acceleration when available in the browser settings
// need to be disabled
replayImages.forEach((img) => {
Expand All @@ -222,7 +222,14 @@ export default function CameraDetailsPage() {
<div className="camera-page">
<div className="page-header">
<Container>
<a onClick={returnHandler} className="back-link">
<a className="back-link"
onClick={returnHandler}
onKeyDown={(keyEvent) => {
if (keyEvent.keyCode == 13) {
returnHandler();
}
}}>

<FontAwesomeIcon icon={faArrowLeft} />
Back to last page
</a>
Expand Down
9 changes: 8 additions & 1 deletion src/frontend/src/pages/EventsListPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,14 @@ export default function EventsListPage() {
<div className="events-list">
{ !showLoader && processedEvents.map(
(e) => (
<div className="card-selector" key={e.id} onClick={() => handleRoute(e)}>
<div className="card-selector" key={e.id}
onClick={() => handleRoute(e)}
onKeyDown={(keyEvent) => {
if (keyEvent.keyCode == 13) {
handleRoute(e);
}
}}>

<EventCard
className="event"
event={e}
Expand Down
Loading