Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBC22-1880: styling for route search swap button #338

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

tyrel-oxd
Copy link
Contributor

No description provided.

@tyrel-oxd tyrel-oxd requested a review from minORC March 25, 2024 18:08
color: black;
border-radius: 32px 32px 32px 32px;
border: 1px 0px 0px 0px;
opacity: 0px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate line for border can be removed, and opacity line is invalid. Please remove these two lines 17, 18.

@@ -5,6 +5,25 @@
padding: 1rem 1rem 0;
z-index: 5;

.swap-button{
position: relative;
display: row;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is invalid, please remove.

top: -53px;
left: 292px;
padding: 8px 4px 8px 4px;
gap: 6px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this doing for the button?

left: 292px;
padding: 8px 4px 8px 4px;
gap: 6px;
color: black;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong colour for button as well as hover state colour.

@minORC minORC merged commit 871e4fd into main Mar 25, 2024
3 checks passed
@minORC minORC deleted the feature/DBC22-1880 branch March 25, 2024 18:55
@ray-oxd ray-oxd restored the feature/DBC22-1880 branch March 26, 2024 01:13
@ray-oxd
Copy link
Collaborator

ray-oxd commented Mar 26, 2024

@tyrel-oxd button is not visible in delay/cam list pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants