-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBC22-2802: Added time and targets for route notifications settings. #811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Looks like we have to scroll to the right in mobile by default to see the full form, is this intended? Please confirm with James as needed
- Please remove advisories and environment canada weather effects from the list for now
- Users can click "Enable notifications" without selecting a time option or what they want to be notified about. Please confirm with UX whether we need to force a selection in each of the sections.
|
9265a69
to
afe0b5a
Compare
Removed the targets that are not implemented yet from the list, and fixed overflowing mobile layout. Also added the missing layouts for specific date and date range. Still missing: validation of the form, including an error message when none of the targets list checkboxes are checked, and time/date range validation. |
77cc66a
to
714607e
Compare
474fd80
to
0b5e9b1
Compare
for https://moti-imb.atlassian.net/browse/DBC22-2802 and https://moti-imb.atlassian.net/browse/DBC22-2805