Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBC22-2802: Added time and targets for route notifications settings. #811

Merged
merged 10 commits into from
Jan 29, 2025

Conversation

minORC
Copy link
Collaborator

@minORC minORC commented Jan 17, 2025

@minORC minORC requested a review from ray-oxd January 17, 2025 00:12
Copy link
Collaborator

@ray-oxd ray-oxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  1. Looks like we have to scroll to the right in mobile by default to see the full form, is this intended? Please confirm with James as needed
  2. Please remove advisories and environment canada weather effects from the list for now
  3. Users can click "Enable notifications" without selecting a time option or what they want to be notified about. Please confirm with UX whether we need to force a selection in each of the sections.

@ray-oxd
Copy link
Collaborator

ray-oxd commented Jan 21, 2025

  1. The date/time selection is missing the date range/specific dates options. Note on desktop we have a dropdown in the design for these, but we are missing a toggle/dropdown of some kind in the mobile design.

@minORC minORC force-pushed the feature/DBC22-2802 branch 2 times, most recently from 9265a69 to afe0b5a Compare January 23, 2025 00:24
@minORC
Copy link
Collaborator Author

minORC commented Jan 23, 2025

Removed the targets that are not implemented yet from the list, and fixed overflowing mobile layout. Also added the missing layouts for specific date and date range.
Also clarified with UX that the default selection will be "Immediately and all the time" and all the checkboxes under the targets list.

Still missing: validation of the form, including an error message when none of the targets list checkboxes are checked, and time/date range validation.

@ray-oxd ray-oxd force-pushed the feature/DBC22-2802 branch 2 times, most recently from 77cc66a to 714607e Compare January 24, 2025 20:47
@ray-oxd ray-oxd force-pushed the feature/DBC22-2802 branch from 474fd80 to 0b5e9b1 Compare January 29, 2025 03:17
@ray-oxd ray-oxd merged commit 15e41f4 into main Jan 29, 2025
3 checks passed
@ray-oxd ray-oxd deleted the feature/DBC22-2802 branch January 29, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants