Skip to content

Commit

Permalink
fix: too few max replicas
Browse files Browse the repository at this point in the history
This should lower the amount of email alert noise
  • Loading branch information
trev-dev committed Mar 20, 2024
1 parent 5e4fe00 commit fbbe0a0
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/deploy-to.openshift-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ env:
COMMON_NAMESPACE: ${{ secrets.COMMON_NAMESPACE_NO_ENV }}
TAG: "latest"
MIN_REPLICAS_DEV: "1"
MAX_REPLICAS_DEV: "1"
MAX_REPLICAS_DEV: "2"
MIN_CPU: "15m"
MAX_CPU: "300m"
MIN_MEM: "650Mi"
Expand Down Expand Up @@ -167,4 +167,4 @@ jobs:
- name: ZAP Scan
uses: zaproxy/action-api-scan@v0.2.0
with:
target: 'https://${{ env.APP_NAME }}-${{ env.OPENSHIFT_NAMESPACE_DEV }}.apps.silver.devops.gov.bc.ca/v3/api-docs'
target: 'https://${{ env.APP_NAME }}-${{ env.OPENSHIFT_NAMESPACE_DEV }}.apps.silver.devops.gov.bc.ca/v3/api-docs'
4 changes: 2 additions & 2 deletions .github/workflows/deploy-to.openshift-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ env:
TAG: "latest"
TARGET_ENV: "prod"
MIN_REPLICAS: "3"
MAX_REPLICAS: "3"
MAX_REPLICAS: "4"
MIN_CPU: "25m"
MAX_CPU: "300m"
MIN_MEM: "650Mi"
Expand Down Expand Up @@ -128,4 +128,4 @@ jobs:
|| true && echo "Rollout in progress"
oc logs -f dc/${{ env.SPRING_BOOT_IMAGE_NAME }}
# Get status, returns 0 if rollout is successful
oc rollout status dc/${{ env.SPRING_BOOT_IMAGE_NAME }}
oc rollout status dc/${{ env.SPRING_BOOT_IMAGE_NAME }}
4 changes: 2 additions & 2 deletions .github/workflows/deploy-to.openshift-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ env:
COMMON_NAMESPACE: ${{ secrets.COMMON_NAMESPACE_NO_ENV }}
TAG: ${{ github.event.inputs.tag }}
MIN_REPLICAS_TEST: "2"
MAX_REPLICAS_TEST: "2"
MAX_REPLICAS_TEST: "3"
MIN_CPU: "25m"
MAX_CPU: "150m"
MIN_MEM: "650Mi"
Expand Down Expand Up @@ -135,4 +135,4 @@ jobs:
- name: ZAP Scan
uses: zaproxy/action-api-scan@v0.2.0
with:
target: 'https://${{ env.APP_NAME }}-${{ env.OPENSHIFT_NAMESPACE_TEST }}.apps.silver.devops.gov.bc.ca/v3/api-docs'
target: 'https://${{ env.APP_NAME }}-${{ env.OPENSHIFT_NAMESPACE_TEST }}.apps.silver.devops.gov.bc.ca/v3/api-docs'

0 comments on commit fbbe0a0

Please sign in to comment.