updating jacoco to try to include test coverage. code cleanup

bcgov · Feb 7, 2024 · a6573a5 · a6573a5
1 parent b144019
commit a6573a5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/api/pom.xml b/api/pom.xml
@@ -272,7 +272,7 @@
         <plugin>
           <groupId>org.jacoco</groupId>
           <artifactId>jacoco-maven-plugin</artifactId>
-          <version>0.8.4</version>
+          <version>0.8.8</version>
         </plugin>
         <plugin>
           <groupId>org.hibernate.orm.tooling</groupId>

diff --git a/...rc/test/java/ca/bc/gov/educ/penreg/api/service/StudentRegistrationContactServiceTest.java b/...rc/test/java/ca/bc/gov/educ/penreg/api/service/StudentRegistrationContactServiceTest.java
@@ -63,6 +63,6 @@ public void testGetStudentRegistrationContactEmailsByMincode_givenDifferentInput
     String mincodeNotExist = "123546789";
     when(this.restUtils.getStudentRegistrationContactList(mincodeNotExist)).thenReturn(studentRegistrationContactMap.get(mincodeNotExist));
     var dataList2 = this.service.getStudentRegistrationContactEmailsByMincode(mincodeNotExist);
-    assertThat(dataList2).hasSize(0);
+    assertThat(dataList2).isEmpty();
   }
 }