Skip to content

Commit

Permalink
Merge pull request #204 from bcgov/fix/url-digital-id
Browse files Browse the repository at this point in the history
Changing URL to not use a trailing / eg. www.url.com/?query=xxx for q…
  • Loading branch information
arcshiftsolutions authored Nov 6, 2023
2 parents f465879 + 967f29e commit ea20f8a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion backend/src/components/request.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ async function getLatestRequest(token, digitalID, requestType, setReplicateStatu
let sagaInProgress = false;
const url = config.get(`${requestType}:apiEndpoint`);
try {
let data = await getData(token, `${url}/?digitalID=${digitalID}`, correlationID);
let data = await getData(token, `${url}?digitalID=${digitalID}`, correlationID);
request = lodash.maxBy(data, 'statusUpdateDate') || null;
if(request) {
sagaInProgress = await redisUtil.isSagaInProgressForDigitalID(request.digitalID);
Expand Down
4 changes: 2 additions & 2 deletions backend/tests/unit/components/request.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ describe('getLatestRequest', () => {
expect(result).toBeTruthy();
expect(result.statusUpdateDate).toEqual('2020-03-05T07:05:59');
expect(result.digitalID).toBeNull();
expect(spy).toHaveBeenCalledWith('token', config.get('studentRequest:apiEndpoint') + `/?digitalID=${digitalID}`, correlationID);
expect(spy).toHaveBeenCalledWith('token', config.get('studentRequest:apiEndpoint') + `?digitalID=${digitalID}`, correlationID);
});

it('should return null if no requests', async () => {
Expand All @@ -157,7 +157,7 @@ describe('getLatestRequest', () => {
const result = await changeRequest.__get__('getLatestRequest')('token', digitalID, requestType, setReplicateStatus, correlationID);

expect(result).toBeNull();
expect(spy).toHaveBeenCalledWith('token', config.get('studentRequest:apiEndpoint') + `/?digitalID=${digitalID}`, correlationID);
expect(spy).toHaveBeenCalledWith('token', config.get('studentRequest:apiEndpoint') + `?digitalID=${digitalID}`, correlationID);
});

it('should return null if getData return NOT_FOUND', async () => {
Expand Down

0 comments on commit ea20f8a

Please sign in to comment.