Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the workplan filters multi select #1071

Merged
merged 10 commits into from
Oct 19, 2023
Merged

Make the workplan filters multi select #1071

merged 10 commits into from
Oct 19, 2023

Conversation

jadmsaadaot
Copy link
Collaborator

task#927

Description:

  • Make filters multi select
  • Take out event list table to separate component
  • Make the loading skeleton for all the workplan
  • Finish loading workphases and add error text if it failed to load
  • Add a utility function for filter options for master track table
  • Take MasterTrackTable to a separate component

@jadmsaadaot jadmsaadaot self-assigned this Oct 19, 2023
@jadmsaadaot jadmsaadaot marked this pull request as ready for review October 19, 2023 18:31
dinesh-aot
dinesh-aot reviewed Oct 19, 2023
View reviewed changes
epictrack-api/manage.py Outdated
@@ -24,7 +24,7 @@
from flask.cli import FlaskGroup


APP = create_app(run_mode='migration')
APP = create_app()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to remove the 'run_mode'. I know that you did this so that you can run the application.right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revert this, I can always just remove it temporarily locally to run it

@dinesh-aot dinesh-aot merged commit 099e248 into bcgov:develop Oct 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saravanpa-aot saravanpa-aot Awaiting requested review from saravanpa-aot

@salabh-aot salabh-aot Awaiting requested review from salabh-aot

@TomChapmanGov TomChapmanGov Awaiting requested review from TomChapmanGov

@dinesh-aot dinesh-aot Awaiting requested review from dinesh-aot

Assignees

@jadmsaadaot jadmsaadaot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jadmsaadaot @dinesh-aot