Work modal #1079
Merged
Work modal #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinesh-aot
reviewed
Oct 24, 2023
epictrack-api/migrations/versions/eed10a65e3c3_make_columns_not_nullable.py
Show resolved
Hide resolved
dinesh-aot
reviewed
Oct 24, 2023
| validate=validate.Length(max=500), | ||
| required=True, | ||
| ) | ||
| long_description = fields.Str( | ||
| metadata={"description": "Long description of work"}, | ||
| epic_description = fields.Str( |
There was a problem hiding this comment.
Any particular reason for this name change. Cz the long description would serve the purpose. In the front end we keep changing the label, but it may not be possible to change the backend column name all the time.
There was a problem hiding this comment.
Only reason for changing the backend column name is so it matched what we have on the front end. Otherwise we just have to remember that report description (frontend) is the short description (backend) and that epic description (frontend) is long description (backend).
There was a problem hiding this comment.
But if you want I can revert all the backend changes
dinesh-aot
reviewed
Oct 24, 2023
| @@ -26,13 +26,13 @@ class WorkBodyParameterSchema(RequestBodyParameterSchema): | |||
| required=True, | |||
| ) | |||
|
|
|||
| short_description = fields.Str( | |||
| metadata={"description": "Short description of work"}, | |||
| report_description = fields.Str( | |||
dinesh-aot
reviewed
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1001