Added Model and resouce for work status and issues #1155
Conversation
saravanpa-aot
requested review from
dinesh-aot,
salabh-aot and
jadmsaadaot
as code owners
| work_issue_id = Column(ForeignKey('work_issues.id'), nullable=False) | ||
| work_issue = relationship('WorkIssues', back_populates='updates') | ||
|
|
||
| def as_dict(self): # pylint:disable=arguments-differ |
There was a problem hiding this comment.
Even if you don't put this as_dict() method here, you still be able to get it from the BaseModel
There was a problem hiding this comment.
do we even need as_dict? since we use marshamallow , i wasnt sure..just kept it there..
There was a problem hiding this comment.
do we even need as_dict? since we use marshamallow , i wasnt sure..just kept it there..
Sometimes I use it when I update stuff. like, status.update(status.as_dict(recursive=False)). I want to pass a dict. yes, I can dump a json using Marshmallow response. I haven't tried that. Lets check the possibility
There was a problem hiding this comment.
removed for now..
| @@ -105,3 +105,5 @@ | |||
| API.add_namespace(RESPONSIBILITY_API, path="/responsibilities") | |||
| API.add_namespace(OUTCOME_CONFIGURATION_API, path="/outcome-configurations") | |||
| API.add_namespace(ACT_SECTION_API, path="/act-sections") | |||
| API.add_namespace(WORK_STATUS_API, path='/work/<int:work_id>/status') | |||
There was a problem hiding this comment.
Do you think it would be good to have plurals in the URL like statuses instead of status
There was a problem hiding this comment.
changed to statuses
Related
tickets #1107,
#920