Make the search bar auto complete #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadmsaadaot
requested review from
dinesh-aot,
salabh-aot and
saravanpa-aot
as code owners
| // Fetch project names from the backend when searchText changes | ||
| useEffect(() => { | ||
| const fetchProjectNames = async () => { | ||
| // Replace this with your actual backend API call |
There was a problem hiding this comment.
Is this comment still relevant?
There was a problem hiding this comment.
not, I should remove this
| @@ -5,8 +5,11 @@ import { MasterBase } from "../../models/type"; | |||
| import { ListType } from "../../models/code"; | |||
|
|
|||
| class ProjectService implements ServiceBase { | |||
| async getAll(return_type?: string) { | |||
| return await http.GetRequest(Endpoints.Projects.PROJECTS, { return_type }); | |||
| async getAll(return_type?: string, with_works?: boolean) { | |||
There was a problem hiding this comment.
with_works? is includeWorks better?
There was a problem hiding this comment.
i am not sure you want project which has a work or you wanna include a work ..so plz feel to disregard this
There was a problem hiding this comment.
return_type ? is it the project type?
There was a problem hiding this comment.
I need only the project with works, I don't need to include the works info.
There was a problem hiding this comment.
return_type is not my addition, it's already there. It decides what schema to use
TomChapmanGov
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.zenhub.com/workspaces/epictrack-63891ea941d309001fa292cf/issues/gh/bcgov/epic.track/1282
Details: