special field enhancements #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinesh-aot
requested review from
salabh-aot,
jadmsaadaot and
saravanpa-aot
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1663 +/- ##
==========================================
Coverage ? 61.93%
==========================================
Files ? 248
Lines ? 8201
Branches ? 0
==========================================
Hits ? 5079
Misses ? 3122
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jadmsaadaot
reviewed
Jan 15, 2024
| letterSpacing: "-0.32px", | ||
| // fontSize: "15px", | ||
| // lineHeight: "24px", | ||
| // letterSpacing: "-0.32px", |
There was a problem hiding this comment.
can we remove all together instead of commenting out?
There was a problem hiding this comment.
@jadmsaadaot Updated as per your comments. Also, updated the enhancements done in detail in the description above. Please check.
There was a problem hiding this comment.
thanks for the changes, approved
jadmsaadaot
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1515