-
Notifications
You must be signed in to change notification settings - Fork 17
Restrict workplan tab actions #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1672 +/- ##
==========================================
Coverage ? 63.06%
==========================================
Files ? 248
Lines ? 8235
Branches ? 0
==========================================
Hits ? 5193
Misses ? 3042
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -241,8 +271,14 @@ def bulk_update(cls, data: dict): | |||
return "Updated successfully" | |||
|
|||
@classmethod | |||
def bulk_delete_tasks(cls, task_ids: List): | |||
def bulk_delete_tasks(cls, task_ids: List, work_id: int): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dinesh-aot @saravanpa-aot should we add a "Delete" role for operations like this. We only have Create and Edit now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Question. I think we should create a role called Delete. @saravanpa-aot thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this ticket for the Delete role https://app.zenhub.com/workspaces/epictrack-63891ea941d309001fa292cf/issues/gh/bcgov/epic.track/1679, happy to merge this once approved
cbcb199
to
a42d7b3
Compare
added https://app.zenhub.com/workspaces/epictrack-63891ea941d309001fa292cf/issues/gh/bcgov/epic.track/1681 |
https://app.zenhub.com/workspaces/epictrack-63891ea941d309001fa292cf/issues/gh/bcgov/epic.track/1579
Details: