Skip to content

Restrict workplan tab actions #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

jadmsaadaot
Copy link
Collaborator

https://app.zenhub.com/workspaces/epictrack-63891ea941d309001fa292cf/issues/gh/bcgov/epic.track/1579

Details:

  • Use Restrict component to wrap buttons
  • Add auth_check for all the services in the backend
  • Add work_id in the request body to some bulk operations to be able to use it in auth_check

@jadmsaadaot jadmsaadaot self-assigned this Jan 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@bf2fcba). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1672   +/-   ##
==========================================
  Coverage           ?   63.06%           
==========================================
  Files              ?      248           
  Lines              ?     8235           
  Branches           ?        0           
==========================================
  Hits               ?     5193           
  Misses             ?     3042           
  Partials           ?        0           
Flag Coverage Δ
epictrack-api 63.06% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jadmsaadaot jadmsaadaot marked this pull request as ready for review January 16, 2024 00:39
@@ -241,8 +271,14 @@ def bulk_update(cls, data: dict):
return "Updated successfully"

@classmethod
def bulk_delete_tasks(cls, task_ids: List):
def bulk_delete_tasks(cls, task_ids: List, work_id: int):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinesh-aot @saravanpa-aot should we add a "Delete" role for operations like this. We only have Create and Edit now

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Question. I think we should create a role called Delete. @saravanpa-aot thoughts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this ticket for the Delete role https://app.zenhub.com/workspaces/epictrack-63891ea941d309001fa292cf/issues/gh/bcgov/epic.track/1679, happy to merge this once approved

@jadmsaadaot
Copy link
Collaborator Author

image
pylint is complaining that the module services/event.py is too big, exceeds lines of code limit. Fixing that would some refactoring and is really out of scope of this, can we ignore it?

@saravanpa-aot
Copy link
Collaborator

image pylint is complaining that the module services/event.py is too big, exceeds lines of code limit. Fixing that would some refactoring and is really out of scope of this, can we ignore it?

sure... plz create a ticket for refactoring..put the above screenshot

@jadmsaadaot
Copy link
Collaborator Author

image pylint is complaining that the module services/event.py is too big, exceeds lines of code limit. Fixing that would some refactoring and is really out of scope of this, can we ignore it?

sure... plz create a ticket for refactoring..put the above screenshot

added https://app.zenhub.com/workspaces/epictrack-63891ea941d309001fa292cf/issues/gh/bcgov/epic.track/1681

@dinesh-aot dinesh-aot merged commit 6569974 into bcgov:develop Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants