Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRACK-190: fix setting event actual when previous event deleted #2411

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

tom0827
Copy link
Collaborator

@tom0827 tom0827 commented Sep 28, 2024

https://eao-dst.atlassian.net/jira/software/c/projects/TRACK/boards/10?selectedIssue=TRACK-190

When event actual date is set we perform checks to see if previous events actual date are set. Fixed bug where we were checking previous event actual date was set even if the event had been deleted

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@abcea80). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2411   +/-   ##
==========================================
  Coverage           ?   77.82%           
==========================================
  Files              ?      293           
  Lines              ?     9808           
  Branches           ?        0           
==========================================
  Hits               ?     7633           
  Misses             ?     2175           
  Partials           ?        0           
Flag Coverage Δ
epictrack-api 77.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tom0827 tom0827 changed the title fix setting event actual when previous event deleted TRACK-190: fix setting event actual when previous event deleted Sep 28, 2024
@tom0827 tom0827 merged commit 5d03bb0 into bcgov:develop Oct 4, 2024
4 checks passed
@tom0827 tom0827 deleted the TRACK-190 branch November 26, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants