Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-633 Dockerize react-app #2053

Merged
merged 4 commits into from
Jan 24, 2024
Merged

PIMS-633 Dockerize react-app #2053

merged 4 commits into from
Jan 24, 2024

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Jan 19, 2024

🎯 Summary

PIMS-633

Changes

  • Adds a Dockerfile to build the react-app frontend using NGINX
  • Adds an entry in docker-compose.yaml to start this container

Testing

  • Start the container with docker-compose up -d --build react-app
  • Navigate to the page (localhost:3000) and test that the page is working

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@GrahamS-Quartech
Copy link
Contributor

Looks good, I was able to build and access the container with docker compose on my machine. Ideally, there could be an entry in the makefile to invoke the docker-compose command as well.

@dbarkowsky
Copy link
Collaborator Author

dbarkowsky commented Jan 23, 2024

Looks good, I was able to build and access the container with docker compose on my machine. Ideally, there could be an entry in the makefile to invoke the docker-compose command as well.

To build the entire suite of containers or just this one?
You can build this one specifically by using any of the commands that take the n argument, like make rebuild n=react-app. That would trigger the express-api and postgres containers as well, because of the reliances.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Container builds as expected and no apparent issues.

@dbarkowsky dbarkowsky merged commit 337d085 into main Jan 24, 2024
3 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-633-Dockerize-react-app branch January 24, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants