feat: revocation improvement #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
| { | ||
| names: ['given_names', 'family_name', 'picture'], | ||
| restrictions: verifiedPersonRestrictions, | ||
| nonRevoked: { to: now() }, |
There was a problem hiding this comment.
If a user has first opened the wallet and then afterwards a credential is revoked, will it still be accepted because it's after the now()?
There was a problem hiding this comment.
now() gets called whenever the template is fetched, so any time the QR code is refreshed the time will be updated. I've tested the changes and it seems to be working as expected, if a credential is revoked before receiving a proof then it will not be valid. I've added the functionality so support this in my bifold PR.
bryce-mcmath
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added revocation intervals to proof templates to ensure that mobile verifiers don't accept revoked credentials.
Depends on: openwallet-foundation/bifold-wallet#972
Resolves: #1439