Merge pull request #145 from bcgov/bugfix/appmount

Fix getGitRevision mishandling HEAD file read
bcgov · Nov 3, 2023 · 5780f57 · 5780f57
2 parents 9351975 + 34c3709
commit 5780f57
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/app/src/components/utils.ts b/app/src/components/utils.ts
@@ -26,14 +26,13 @@ export function getGitRevision(): string {
       .toString()
       .trim();
 
-    let fileRead: string = '';
     if (head.indexOf(':') === -1) {
-      fileRead = readFileSync(join(__dirname, `${gitDir}/${head.substring(5)}`), 'utf8')
+      return head;
+    } else {
+      return readFileSync(join(__dirname, `${gitDir}/${head.substring(5)}`), 'utf8')
         .toString()
         .trim();
     }
-
-    return head.indexOf(':') === -1 ? head : (fileRead as string);
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
   } catch (err: any) {
     log.warn(err.message, { function: 'getGitRevision' });