Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC-3303: Align BCBox with V0.6 file upload changes #111

Merged
merged 7 commits into from
Aug 18, 2023
Merged

Conversation

wilwong89
Copy link
Contributor

Description

Update BCBox to use new API for COMS.
Change createObject and updateObject methods to use PUT instead of POST
Upload as octet-stream

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Made an assumption that objects passed to objService will be of File type.

@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 75% ( 51 / 68 )
Methods: 62.5% ( 5 / 8 )
Lines: 82.61% ( 38 / 46 )
Branches: 57.14% ( 8 / 14 )

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Coverage Report (Frontend)

Totals Coverage
Statements: 37.84% ( 445 / 1176 )
Methods: 38.11% ( 101 / 265 )
Lines: 44.75% ( 307 / 686 )
Branches: 16.44% ( 37 / 225 )

Copy link
Member

@jujaga jujaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely glad this pathway actually works with axios without too much relative headache. That being said, we need to make sure we're actually doing some proper handling of the mimetype detection and not just calling everything an octet-stream.

frontend/src/utils/utils.ts Outdated Show resolved Hide resolved
frontend/src/services/objectService.ts Show resolved Hide resolved
frontend/src/services/objectService.ts Outdated Show resolved Hide resolved
frontend/src/services/objectService.ts Outdated Show resolved Hide resolved
frontend/src/services/objectService.ts Outdated Show resolved Hide resolved
frontend/src/services/objectService.ts Outdated Show resolved Hide resolved
@jujaga jujaga merged commit 5275301 into master Aug 18, 2023
14 checks passed
@jujaga jujaga deleted the task/SC-3033 branch August 18, 2023 23:47
@jujaga jujaga mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants