-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SC-3303: Align BCBox with V0.6 file upload changes #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwong89
force-pushed
the
task/SC-3033
branch
from
August 15, 2023 18:32
e0ee5d6
to
5db1a1f
Compare
jujaga
reviewed
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely glad this pathway actually works with axios without too much relative headache. That being said, we need to make sure we're actually doing some proper handling of the mimetype detection and not just calling everything an octet-stream.
jujaga
approved these changes
Aug 16, 2023
norrisng-bc
approved these changes
Aug 16, 2023
jujaga
reviewed
Aug 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update BCBox to use new API for COMS.
Change createObject and updateObject methods to use PUT instead of POST
Upload as octet-stream
Types of changes
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
Further comments
Made an assumption that objects passed to objService will be of
File
type.