Divide COMS object search request to limit URL length #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
TimCsaky
force-pushed
the
bug/limit-url
branch
from
3e1e9b8
to
e61e770
Compare
Coverage Report (Frontend)
|
jujaga
reviewed
Aug 28, 2023
jujaga
approved these changes
Aug 28, 2023
wilwong89
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3330
to load the objects table, if there are more than about 50 objects some browsers will show errors, because the COMS request url contains so many
objectId's and is too long.In object search service function, i have split into multiple requests, each time, passing an acceptable number of the
objectId'sTypes of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments