Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-334 UI Fixes #1164

Merged
merged 2 commits into from
Nov 7, 2023
Merged

SIMSBIOHUB-334 UI Fixes #1164

merged 2 commits into from
Nov 7, 2023

Conversation

jeznorth
Copy link
Contributor

@jeznorth jeznorth commented Nov 6, 2023

Links to Jira Tickets

  • SIMSBIOHUB-334

Description of Changes

  • Minor UI polish and updating notification content.

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1164 (12f3f29) into dev-staging (a359ed2) will decrease coverage by 0.04%.
Report is 1 commits behind head on dev-staging.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           dev-staging    #1164      +/-   ##
===============================================
- Coverage        61.53%   61.49%   -0.04%     
===============================================
  Files              551      551              
  Lines            16652    16657       +5     
  Branches          2548     2551       +3     
===============================================
- Hits             10246    10243       -3     
- Misses            5729     5741      +12     
+ Partials           677      673       -4     
Files Coverage Δ
app/src/contexts/observationsTableContext.tsx 0.00% <ø> (ø)
...ations/observations-table/ObservationComponent.tsx 0.00% <ø> (ø)
...s/observations/sampling-sites/SamplingSiteList.tsx 0.00% <ø> (ø)
...atures/surveys/view/components/SurveyStudyArea.tsx 63.33% <ø> (ø)
app/src/pages/landing/LandingActions.tsx 92.00% <100.00%> (-4.00%) ⬇️

... and 7 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@curtisupshall curtisupshall changed the base branch from dev to dev-staging November 6, 2023 19:01
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@JeremyQuartech JeremyQuartech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally, looks good to me

@curtisupshall curtisupshall merged commit 5468433 into dev-staging Nov 7, 2023
17 of 20 checks passed
@curtisupshall curtisupshall deleted the SIMSBIOHUB-334-UI-Fixes branch November 7, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants