SIMSBIOHUB-345: Display Time in Sampling Periods

[KjartanE]

Links to Jira Tickets

• https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-345

Description of Changes

• Added Time picker for start and end time on sample site periods.
• Database changes include 2 more columns for start,end time.

Testing Notes

• {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1167-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1167-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1167

[codecov]

Codecov Report

Merging #1167 (f91231d) into dev-staging (ec677ac) will decrease coverage by 0.18%.
Report is 2 commits behind head on dev-staging.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           dev-staging    #1167      +/-   ##
===============================================
- Coverage        61.49%   61.32%   -0.18%     
===============================================
  Files              551      552       +1     
  Lines            16657    16702      +45     
  Branches          2551     2570      +19     
===============================================
- Hits             10244    10243       -1     
- Misses            5741     5782      +41     
- Partials           672      677       +5     

Files	Coverage Δ
...{projectId}/survey/{surveyId}/sample-site/index.ts	89.36% <ø> (ø)
...urveyId}/sample-site/{surveySampleSiteId}/index.ts	87.71% <ø> (ø)
api/src/services/sample-method-service.ts	97.22% <ø> (ø)
...features/surveys/components/EditSamplingMethod.tsx	0.00% <ø> (ø)
...s/observations/sampling-sites/SamplingSiteList.tsx	0.00% <0.00%> (ø)
...ervations/observations-table/ObservationsTable.tsx	0.00% <0.00%> (ø)
api/src/repositories/sample-period-repository.ts	68.57% <0.00%> (-8.85%)	⬇️
app/src/features/surveys/components/MethodForm.tsx	0.00% <0.00%> (ø)
...features/surveys/components/SamplingMethodForm.tsx	0.00% <0.00%> (ø)
...ing-sites/edit/components/SampleMethodEditForm.tsx	0.00% <0.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[GrahamS-Quartech]

Couple things I noticed:

• The modal will allow you to set an end time occurring before the start time when the dates are the same.
• If you enter the edit sampling site page, then edit either time period time field and hit Update in that modal, it will update the card with that new time. However if you re-enter that edit modal, the time will have reverted to the previous value.
• I think the layout of how the fields and trash can are arranged could be better but I don't really know what would look best. Maybe check in with Jeremy?

[al-rosenthal]

adding and editing works as expected

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
4.8% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[al-rosenthal]

🕐

[JeremyQuartech]

Tested locally, everything working correctly

[curtisupshall]

Could avoid the trailing whitespace:

primary={[period.start_time, period.end_time].filter(Boolean).join(' to ')}