Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech Debt - General UI Fixes #1176

Merged
merged 18 commits into from
Dec 5, 2023
Merged

Tech Debt - General UI Fixes #1176

merged 18 commits into from
Dec 5, 2023

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Nov 28, 2023 •
edited
Loading

Description of Changes

  • Fixed skeleton loaders
  • General UI fixes

@curtisupshall curtisupshall added Not Ready For Review Addressing feedback and/or refactoring Tech Debt labels Nov 28, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (a6a4c62) 60.34% compared to head (84647ae) 60.32%.

Files Patch % Lines
...ervations/observations-table/ObservationsTable.tsx 0.00% 8 Missing ⚠️
...s/observations/sampling-sites/SamplingSiteList.tsx 0.00% 8 Missing ⚠️
...ations/observations-table/ObservationComponent.tsx 0.00% 7 Missing ⚠️
...c/components/data-grid/DataGridValidationAlert.tsx 0.00% 4 Missing ⚠️
app/src/features/surveys/view/SurveyPage.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1176      +/-   ##
==========================================
- Coverage   60.34%   60.32%   -0.02%     
==========================================
  Files         566      566              
  Lines       17099    17103       +4     
  Branches     2653     2656       +3     
==========================================
  Hits        10318    10318              
- Misses       6096     6100       +4     
  Partials      685      685

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall added Ready For Review PR is ready for review and removed Not Ready For Review Addressing feedback and/or refactoring labels Dec 1, 2023
KjartanE
KjartanE previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Locally, works as intended 🐈

MacQSL
MacQSL previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@curtisupshall curtisupshall dismissed stale reviews from MacQSL and KjartanE via 84647ae December 4, 2023 23:08
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

KjartanE
KjartanE approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

MacQSL
MacQSL approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@curtisupshall curtisupshall merged commit 0e87f1f into dev Dec 5, 2023
18 of 20 checks passed
@curtisupshall curtisupshall deleted the UI-Fixes branch December 5, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MacQSL MacQSL MacQSL approved these changes

@KjartanE KjartanE KjartanE approved these changes

@jeznorth jeznorth Awaiting requested review from jeznorth

Assignees

@KjartanE KjartanE

Labels
Ready For Review PR is ready for review Tech Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curtisupshall @KjartanE @MacQSL @jeznorth