Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Fix migration to drop missed instance of wldtaxonomic_units_id column #1314

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Jun 25, 2024

Links to Jira Tickets

n/a

Description of Changes

Add migration to drop some deprecated columns.

  • Missed an instance of the wldtaxonomic_units_id column. The original migration deprecated old file_type values AND dropped columns in the same PR. Split those two groups of changes into two separate PRs. Will be safe to move existing migration code from the old file to the new file because they all use IF EXISTS.

Disable PR deployment Git Action for Dev->Test PRs (already disabled for Test->Prod PRs)

Testing Notes

Editing an observation record works (does not result in zod validation errors).

Editing the existing migration should be safe, as the commands moved to the new migration all include IF EXISTS.

@NickPhura NickPhura requested a review from MacQSL June 25, 2024 22:45
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.21%. Comparing base (4113630) to head (041c323).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1314   +/-   ##
=======================================
  Coverage   49.21%   49.21%           
=======================================
  Files         639      639           
  Lines       17707    17707           
  Branches     2787     2787           
=======================================
  Hits         8714     8714           
  Misses       8409     8409           
  Partials      584      584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mauberti-bc
mauberti-bc previously approved these changes Jun 25, 2024
Copy link

sonarcloud bot commented Jun 25, 2024

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩴

@NickPhura NickPhura merged commit ce03ca4 into dev Jun 25, 2024
19 checks passed
@NickPhura NickPhura deleted the npBugFix-wldtaxonomic_units_id branch June 25, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants