Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-598: Manage Deployments & Update Telemetry Table #1321

Merged
merged 45 commits into from
Aug 30, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Jul 8, 2024

Description of Changes

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-598
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-415

  • Create and edit deployments in a full page layout instead of a dialog
  • Created frontend telemetryRouter.tsx for telemetry routes
  • Created project/{projectId}/survey/{surveyId}/deployments/{deploymentId} API path
  • Purge old animal/telemetry/device components/hooks.

Testing Notes

  • There's a necessary critterbase bug fix: getting multiple detailed critters by their Id (by including ?format=detailed) always returns an empty array.

Related BCTW PR: bcgov/bctw-api#92

@mauberti-bc mauberti-bc added the Not Ready For Review Addressing feedback and/or refactoring label Jul 8, 2024
@mauberti-bc mauberti-bc marked this pull request as ready for review August 2, 2024 22:18
@mauberti-bc mauberti-bc added Early Feedback Welcome PR is not finished, but early review feedback is welcomed and removed Not Ready For Review Addressing feedback and/or refactoring labels Aug 2, 2024
@NickPhura NickPhura marked this pull request as draft August 9, 2024 17:19
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 36.66107% with 755 lines in your changes missing coverage. Please review.

Project coverage is 47.01%. Comparing base (2fedbf1) to head (c3fbdd9).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...omponents/form/timeline/DeploymentTimelineForm.tsx 0.00% 60 Missing ⚠️
...es/surveys/telemetry/list/SurveyDeploymentList.tsx 0.00% 58 Missing ⚠️
.../telemetry/deployments/edit/EditDeploymentPage.tsx 0.00% 34 Missing ⚠️
...elemetry/device-keys/TelemetryDeviceKeysDialog.tsx 0.00% 29 Missing ⚠️
...emetry/deployments/create/CreateDeploymentPage.tsx 0.00% 27 Missing ⚠️
...try/deployments/components/form/DeploymentForm.tsx 0.00% 26 Missing ⚠️
.../telemetry/device-keys/TelemetryDeviceKeysList.tsx 0.00% 26 Missing ⚠️
.../src/components/fields/AnimalAutocompleteField.tsx 0.00% 25 Missing ⚠️
...mponents/telemetry/SurveySpatialTelemetryTable.tsx 0.00% 25 Missing ⚠️
...d}/survey/{surveyId}/critters/{critterId}/index.ts 60.65% 22 Missing and 2 partials ⚠️
... and 67 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1321      +/-   ##
==========================================
- Coverage   47.92%   47.01%   -0.91%     
==========================================
  Files         737      737              
  Lines       20027    19810     -217     
  Branches     3146     3048      -98     
==========================================
- Hits         9597     9313     -284     
- Misses       9825     9929     +104     
+ Partials      605      568      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc
Copy link
Collaborator Author

  • The deployment form does not seem to submit when the formik validation is happy; the submit button does nothing.
  • The radio buttons for deployment end should be un-selectable (no option selected because the deployment is ongoing)
  • Mortality radio button should be disabled if the animal has no mortalities
  • Reload the table of files in the KeyX dialog upon import to better indicate that the upload succeeded

@NickPhura NickPhura added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Aug 30, 2024
Copy link

sonarcloud bot commented Aug 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@NickPhura NickPhura marked this pull request as ready for review August 30, 2024 18:06
@NickPhura NickPhura self-requested a review August 30, 2024 18:06
@NickPhura NickPhura changed the title Manage Deployments & Update Telemetry Table SIMSBIOHUB-598: Manage Deployments & Update Telemetry Table Aug 30, 2024
@NickPhura NickPhura merged commit b856afd into dev Aug 30, 2024
36 of 39 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-598 branch August 30, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants