-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-587 API: Bulk Captures #1324
Conversation
Openshift URLs for the PR Deployment: |
Regarding the I'm encountering an interesting issue, where the mime type, despite the extension being This blog post actually mentions the same issue: https://christianwood.net/posts/csv-file-upload-validation/ Their conclusion that they just have to add more mime types to the allowed list. The issue doesn't seem to happen through postman. (Everything else downstream works, I just had to add that extra mime type to the openapi schema) |
api/src/paths/project/{projectId}/survey/{surveyId}/critters/{critterId}/captures/import.ts
Outdated
Show resolved
Hide resolved
api/src/services/import-services/csv-import-strategy.interface.ts
Outdated
Show resolved
Hide resolved
Openshift URLs for the PR Deployment: |
I have updated the file schema to include all of these. I can remove some if we think they are not needed. |
api/src/paths/project/{projectId}/survey/{surveyId}/critters/import.test.ts
Outdated
Show resolved
Hide resolved
api/src/paths/project/{projectId}/survey/{surveyId}/critters/import.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Quality Gate passedIssues Measures |
Links to Jira Tickets
Description of Changes (only backend)
Testing Notes