Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environmental variables & sampling methods to standards page #1325

Merged
merged 27 commits into from
Aug 21, 2024

Conversation

LouisThedroux
Copy link
Collaborator

@LouisThedroux LouisThedroux commented Jul 18, 2024

Jira tickets

  • N/A

Description of changes

  • Adds method lookup values and associated qualitative/quantitative options to standards page
  • Adds environmental variables and associated qualitative/quantitative options to standards page
  • Updates the /standards backend

Testing notes

  • Standards page should be visible even if logged out
  • Methods/environment search boxes should filter the results on the standards page

@LouisThedroux LouisThedroux added the Do Not Merge PR should not be merged label Jul 18, 2024
@LouisThedroux LouisThedroux self-assigned this Jul 18, 2024
@LouisThedroux
Copy link
Collaborator Author

This pull request is to replace the method-standards branch and PR

@MacQSL MacQSL marked this pull request as draft July 23, 2024 19:31
@mauberti-bc mauberti-bc changed the title Double standards Add environmental variables & sampling methods to standards page Aug 6, 2024
@mauberti-bc mauberti-bc marked this pull request as ready for review August 6, 2024 21:06
@mauberti-bc mauberti-bc removed the Do Not Merge PR should not be merged label Aug 6, 2024
@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Aug 6, 2024
Copy link

sonarcloud bot commented Aug 19, 2024

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 40.35088% with 102 lines in your changes missing coverage. Please review.

Project coverage is 47.89%. Comparing base (c276f1b) to head (86f9a2e).
Report is 1 commits behind head on dev.

Files Patch % Lines
...tandards/view/components/AccordionStandardCard.tsx 0.00% 13 Missing ⚠️
...tandards/view/environment/EnvironmentStandards.tsx 0.00% 13 Missing ⚠️
...eatures/standards/view/methods/MethodStandards.tsx 0.00% 12 Missing ⚠️
...atures/standards/view/species/SpeciesStandards.tsx 0.00% 10 Missing ⚠️
...standards/view/species/SpeciesStandardsResults.tsx 0.00% 9 Missing ⚠️
app/src/hooks/api/useStandardsApi.ts 27.27% 8 Missing ⚠️
app/src/features/standards/StandardsPage.tsx 0.00% 7 Missing ⚠️
.../standards/view/methods/MethodStandardsResults.tsx 0.00% 7 Missing ⚠️
...features/standards/components/StandardsToolbar.tsx 0.00% 6 Missing ⚠️
...s/view/environment/EnvironmentStandardsResults.tsx 0.00% 5 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1325       +/-   ##
===========================================
- Coverage   75.67%   47.89%   -27.78%     
===========================================
  Files         244      737      +493     
  Lines        9273    20007    +10734     
  Branches     1224     3137     +1913     
===========================================
+ Hits         7017     9582     +2565     
- Misses       1875     9823     +7948     
- Partials      381      602      +221     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@mauberti-bc mauberti-bc merged commit d50c70f into dev Aug 21, 2024
20 of 22 checks passed
@mauberti-bc mauberti-bc deleted the double-standards branch August 21, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants