BugFix: Fix Migration Order of Operations #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
n/a
Description of Changes
The audit triggers need to be created before inserting data into the lookup table (otherwise the create_user column fails the non-null constraint).
I just moved the block of audit/journal trigger sql to above the insert into method_technique sql.
These migrations ran successfully in the PR against a fresh database, which shouldn't have mattered since these tables are all brand new. But something must be different for it to fail against Dev which has existing data. Not exactly sure what the cause is at the moment.
Testing Notes
Migrations should run successfully
I did dry-run this against Dev, and it completes successfully now. Previously was failing due to the create_user non-null constraint on the method_technique table.