Promote DEV to TEST

.github/workflows/addComments.yml

@@ -5,6 +5,7 @@ on:
   pull_request:
     types: [opened, ready_for_review]
     branches-ignore:
+      - test
       - prod
 
 jobs:

api/.pipeline/config.js

@@ -84,13 +84,13 @@ const phases = {
     backboneArtifactIntakePath: '/api/artifact/intake',
     biohubTaxonPath: '/api/taxonomy/taxon',
     biohubTaxonTsnPath: '/api/taxonomy/taxon/tsn',
-    backboneIntakeEnabled: true,
     bctwApiHost: 'https://moe-bctw-api-dev.apps.silver.devops.gov.bc.ca',
     critterbaseApiHost: 'https://moe-critterbase-api-dev.apps.silver.devops.gov.bc.ca/api',
     nodeEnv: 'development',
     s3KeyPrefix: (isStaticDeployment && 'sims') || `local/${deployChangeId}/sims`,
     tz: config.timezone.api,
     sso: config.sso.dev,
+    featureFlags: '',
     logLevel: 'info',
     apiResponseValidationEnabled: true,
     databaseResponseValidationEnabled: true,
@@ -120,14 +120,14 @@ const phases = {
     backboneArtifactIntakePath: '/api/artifact/intake',
     biohubTaxonPath: '/api/taxonomy/taxon',
     biohubTaxonTsnPath: '/api/taxonomy/taxon/tsn',
-    backboneIntakeEnabled: true,
     bctwApiHost: 'https://moe-bctw-api-test.apps.silver.devops.gov.bc.ca',
     critterbaseApiHost: 'https://moe-critterbase-api-test.apps.silver.devops.gov.bc.ca/api',
     nodeEnv: 'production',
     s3KeyPrefix: 'sims',
     tz: config.timezone.api,
     sso: config.sso.test,
     logLevel: 'info',
+    featureFlags: '',
     apiResponseValidationEnabled: true,
     databaseResponseValidationEnabled: true,
     nodeOptions: '--max_old_space_size=3000', // 75% of memoryLimit (bytes)
@@ -156,13 +156,13 @@ const phases = {
     backboneArtifactIntakePath: '/api/artifact/intake',
     biohubTaxonPath: '/api/taxonomy/taxon',
     biohubTaxonTsnPath: '/api/taxonomy/taxon/tsn',
-    backboneIntakeEnabled: false,
     bctwApiHost: 'https://moe-bctw-api-prod.apps.silver.devops.gov.bc.ca',
     critterbaseApiHost: 'https://moe-critterbase-api-prod.apps.silver.devops.gov.bc.ca/api',
     nodeEnv: 'production',
     s3KeyPrefix: 'sims',
     tz: config.timezone.api,
     sso: config.sso.prod,
+    featureFlags: 'API_FF_SUBMIT_BIOHUB',
     logLevel: 'warn',
     apiResponseValidationEnabled: false,
     databaseResponseValidationEnabled: false,

api/.pipeline/lib/api.deploy.js

@@ -38,7 +38,6 @@ const apiDeploy = async (settings) => {
         BACKBONE_INTERNAL_API_HOST: phases[phase].backboneInternalApiHost,
         BACKBONE_INTAKE_PATH: phases[phase].backboneIntakePath,
         BACKBONE_ARTIFACT_INTAKE_PATH: phases[phase].backboneArtifactIntakePath,
-        BACKBONE_INTAKE_ENABLED: phases[phase].backboneIntakeEnabled,
         BIOHUB_TAXON_PATH: phases[phase].biohubTaxonPath,
         BIOHUB_TAXON_TSN_PATH: phases[phase].biohubTaxonTsnPath,
         // BCTW / Critterbase
@@ -68,6 +67,8 @@ const apiDeploy = async (settings) => {
         LOG_LEVEL: phases[phase].logLevel,
         API_RESPONSE_VALIDATION_ENABLED: phases[phase].apiResponseValidationEnabled,
         DATABASE_RESPONSE_VALIDATION_ENABLED: phases[phase].databaseResponseValidationEnabled,
+        // Feature Flags
+        FEATURE_FLAGS: phases[phase].featureFlags,
         // Openshift Resources
         CPU_REQUEST: phases[phase].cpuRequest,
         CPU_LIMIT: phases[phase].cpuLimit,

api/.pipeline/templates/api.dc.yaml

@@ -49,9 +49,6 @@ parameters:
   - name: BACKBONE_ARTIFACT_INTAKE_PATH
     required: true
     description: The publishing intake endpoint path for BioHub Platform artifact submissions. Example "/api/path/to/artifact/intake".
-  - name: BACKBONE_INTAKE_ENABLED
-    required: true
-    description: Controls whether or not SIMS will submit DwCA datasets to the BioHub Platform Backbone. Set to "true" to enable it, will be disabled by default otherwise.
   - name: BIOHUB_TAXON_TSN_PATH
     required: true
     description: API path for BioHub Platform Backbone taxon TSN endpoint. Example "/api/path/to/taxon/tsn".
@@ -125,6 +122,10 @@ parameters:
     value: 'false'
   - name: DATABASE_RESPONSE_VALIDATION_ENABLED
     value: 'false'
+  # Feature Flags
+  - name: FEATURE_FLAGS
+    description: Used to identify features that should be temporarily disabled/hidden. Must be a comma delimited list of keywords.
+    value: ''
   # GCNotify
   - name: GCNOTIFY_API_SECRET
     description: Secret for gcnotify api key
@@ -231,8 +232,6 @@ objects:
                   value: ${BACKBONE_INTAKE_PATH}
                 - name: BACKBONE_ARTIFACT_INTAKE_PATH
                   value: ${BACKBONE_ARTIFACT_INTAKE_PATH}
-                - name: BACKBONE_INTAKE_ENABLED
-                  value: ${BACKBONE_INTAKE_ENABLED}
                 - name: BIOHUB_TAXON_TSN_PATH
                   value: ${BIOHUB_TAXON_TSN_PATH}
                 - name: BIOHUB_TAXON_PATH
@@ -344,6 +343,8 @@ objects:
                   value: ${GCNOTIFY_EMAIL_URL}
                 - name: GCNOTIFY_SMS_URL
                   value: ${GCNOTIFY_SMS_URL}
+                - name: FEATURE_FLAGS
+                  value: ${FEATURE_FLAGS}
               image: ' '
               imagePullPolicy: Always
               ports:

api/.vscode/settings.json

@@ -1,3 +1,4 @@
 {
-  "editor.defaultFormatter": "esbenp.prettier-vscode"
+  "editor.defaultFormatter": "esbenp.prettier-vscode",
+  "typescript.preferences.importModuleSpecifier": "non-relative"
 }