Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Remove Duplicate Environment Columns in Observations Table #1387

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Oct 2, 2024

Links to Jira Tickets

Description of Changes

  • Changed SELECT to SELECT DISTINCT when retrieving quantitative environment definitions
  • Fixes a bug where if a quantitative environment value is given for 2 or more records while editing, that environment variable's column gets duplicated in the observations table

Testing Notes

  • When editing 2 rows and adding a quantitative environment value to both (eg. setting air temperature for both records), the modified measurement's column should not be duplicated

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.34%. Comparing base (3a24789) to head (8250e85).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1387   +/-   ##
=======================================
  Coverage   46.34%   46.34%           
=======================================
  Files         773      773           
  Lines       20834    20834           
  Branches     3146     3146           
=======================================
  Hits         9656     9656           
  Misses      10598    10598           
  Partials      580      580           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good, nice catch!

Tried some of the other SQL in that repository as well, but they all worked as expected.

Copy link

sonarcloud bot commented Oct 2, 2024

@NickPhura NickPhura merged commit 98b4db5 into dev Oct 2, 2024
22 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-624 branch October 2, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants