Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Duration to Sampling Period UI Table #1414

Merged
merged 14 commits into from
Nov 12, 2024
Merged

Add Duration to Sampling Period UI Table #1414

merged 14 commits into from
Nov 12, 2024

Conversation

LouisThedroux
Copy link
Collaborator

Links to Jira Tickets

NA

Description of Changes

A new column, duration, has been added to the sampling period table.

The duration is calculated by determining the difference between the start_date/start_time and the end_date/end_time fields.

@LouisThedroux LouisThedroux added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.30%. Comparing base (1ab1e64) to head (f737830).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...-information/periods/table/SamplingPeriodTable.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1414      +/-   ##
==========================================
+ Coverage   46.24%   46.30%   +0.05%     
==========================================
  Files         784      784              
  Lines       21207    21225      +18     
  Branches     3189     3194       +5     
==========================================
+ Hits         9808     9828      +20     
+ Misses      10812    10810       -2     
  Partials      587      587              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package-lock.json Outdated Show resolved Hide resolved
@LouisThedroux LouisThedroux self-assigned this Oct 30, 2024
@mauberti-bc mauberti-bc changed the title Added a duration calculator for the sampling period information Add Duration to Sampling Period UI Table Oct 31, 2024
@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Oct 31, 2024
app/src/utils/datetime.ts Outdated Show resolved Hide resolved
@NickPhura
Copy link
Collaborator

NickPhura commented Oct 31, 2024

We should add some unit tests as well, for datetime.ts.
They should be fairly straightforward to write, since there is no rendering or api calls to worry about.

@mauberti-bc
Copy link
Collaborator

We should add some unit tests as well, for datetime.ts. They should be fairly straightforward to write, since there is no rendering or api calls to worry about.

Roger, I pushed up a test file for datetime.ts. Some tests are failing due to a timezone issue, where the test framework seems to treat local time as PDT (UTC-8) instead of PST (UTC-7) despite the main app correctly using PST. Haven't been able to figure it out 😖 (We will switch to PDT on Nov. 3 when we roll back the clocks)

Copy link

sonarcloud bot commented Nov 12, 2024

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌡️

@MacQSL MacQSL merged commit 5203f31 into dev Nov 12, 2024
23 checks passed
@MacQSL MacQSL deleted the duration-column branch November 12, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants