-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Duration to Sampling Period UI Table #1414
Conversation
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1414 +/- ##
==========================================
+ Coverage 46.24% 46.30% +0.05%
==========================================
Files 784 784
Lines 21207 21225 +18
Branches 3189 3194 +5
==========================================
+ Hits 9808 9828 +20
+ Misses 10812 10810 -2
Partials 587 587 ☔ View full report in Codecov by Sentry. |
…effects github checks but whatever
app/src/features/surveys/sampling-information/periods/table/SamplingPeriodTable.tsx
Outdated
Show resolved
Hide resolved
We should add some unit tests as well, for |
Roger, I pushed up a test file for datetime.ts. Some tests are failing due to a timezone issue, where the test framework seems to treat local time as PDT (UTC-8) instead of PST (UTC-7) despite the main app correctly using PST. Haven't been able to figure it out 😖 (We will switch to PDT on Nov. 3 when we roll back the clocks) |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌡️
Links to Jira Tickets
NA
Description of Changes
A new column, duration, has been added to the sampling period table.
The duration is calculated by determining the difference between the start_date/start_time and the end_date/end_time fields.