Fixed original tests.

bcgov · Jun 27, 2024 · 70faa92 · 70faa92
1 parent 6ba8eec
commit 70faa92
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 9 deletions.
diff --git a/cypress/support/commands.ts b/cypress/support/commands.ts
@@ -1,12 +1,12 @@
-Cypress.Commands.add('interceptBusinessSlim', (identifier, legalType, isHistorical) => {
+Cypress.Commands.add('interceptBusinessInfo', (identifier, legalType, isHistorical) => {
   cy.fixture(`business${legalType}`).then((business) => {
     business.identifier = identifier
     if (isHistorical) {
       business.state = 'HISTORICAL'
     }
     cy.intercept(
       'GET',
-      `**/api/v2/businesses/${business.identifier}?slim=true`,
+      `**/api/v2/businesses/${business.identifier}`,
       { business })
   })
 })
@@ -70,12 +70,12 @@ Cypress.Commands.add('visitBusinessDash', (identifier = 'BC0871427', legalType =
   ).as('getLdarklyContext')
   cy.intercept('GET', '**/api/v1/orgs/**/products*', { fixture: 'products.json' }).as('getProducts')
   cy.interceptBusinessContact(identifier, legalType).as('getBusinessContact')
-  cy.interceptBusinessSlim(identifier, legalType, isHistorical).as('getBusinessSlim')
+  cy.interceptBusinessInfo(identifier, legalType, isHistorical).as('getBusinessInfo')
   cy.interceptAddresses(legalType).as('getAddresses')
   cy.interceptParties(legalType, isHistorical).as('getParties')
 
   cy.visit(`/${identifier}`)
-  cy.wait(['@getSettings', '@getProducts', '@getBusinessContact', '@getBusinessSlim', '@getAddresses', '@getParties'])
+  cy.wait(['@getSettings', '@getProducts', '@getBusinessContact', '@getBusinessInfo', '@getAddresses', '@getParties'])
   cy.injectAxe()
 })
 
@@ -88,7 +88,7 @@ Cypress.Commands.add('visitBusinessDashAuthError', (identifier = 'BC0871427', le
     { fixture: 'ldarklyContext.json' }
   ).as('getLdarklyContext')
   cy.interceptBusinessContact(identifier, legalType).as('getBusinessContact')
-  cy.interceptBusinessSlim(identifier, legalType).as('getBusinessSlim')
+  cy.interceptBusinessInfo(identifier, legalType).as('getBusinessInfo')
   cy.visit(`/${identifier}`)
   cy.wait(['@getSettingsError'])
   cy.injectAxe()

diff --git a/src/components/bcros/businessDetails/LinkActions.vue b/src/components/bcros/businessDetails/LinkActions.vue
@@ -52,7 +52,7 @@ interface MenuActionItem extends DropdownItem {
 const allActions: ComputedRef<Array<MenuActionItem>> = computed(() => {
   return [
     { // <!-- View/Add Digital Credentials -->
-      showButton: currentBusiness.value.allowedActions.digitalBusinessCard &&
+      showButton: !!currentBusiness.value?.allowedActions?.digitalBusinessCard &&
         getStoredFlag('enable-digital-credentials'),
       disabled: false,
       label: t('button.tombstone.menuAction.digitalCredentials'),

diff --git a/src/components/bcros/businessDetails/Status.vue b/src/components/bcros/businessDetails/Status.vue
@@ -1,5 +1,5 @@
 <template>
-  <header class="flex flex-row gap-1.5 text-sm">
+  <div class="flex flex-row gap-1.5 text-sm">
     <template v-if="!!currentBusiness.identifier">
       <div v-if="currentBusiness.state === BusinessStateE.HISTORICAL" class="flex flex-row gap-1.5">
         <BcrosChips :label="$t('label.business.status.historical')" />
@@ -26,7 +26,7 @@
     <!--        {{ appDescription }}-->
     <!--      </div>-->
     <!--    </template>-->
-  </header>
+  </div>
 </template>
 
 <script setup lang="ts">

diff --git a/src/interfaces/business-i.ts b/src/interfaces/business-i.ts
@@ -56,7 +56,6 @@ export interface BusinessWarningI {
   data?: any // optional extra properties (eg, amalgamationDate)
 }
 
-
 // comments come from business-filings-ui project ApiBusinessIF interface
 export interface BusinessI {
   adminFreeze: boolean

diff --git a/src/stores/business.ts b/src/stores/business.ts
@@ -198,6 +198,9 @@ export const useBcrosBusiness = defineStore('bcros/business', () => {
   })
 
   const isAllowedToFile = (filingType: FilingTypes, filingSubType?: FilingSubTypeE) => {
+    if (!filingType || !currentBusiness.value?.allowedActions?.filing) {
+      return false
+    }
     const requestedFiling = currentBusiness.value.allowedActions.filing.filingTypes
       .find(ft => ft.name === filingType && (filingSubType === undefined || ft.type === filingSubType))
     return !!requestedFiling