Skip to content

Commit

Permalink
24638 - fix: incorrect name in amalgamation application (#87)
Browse files Browse the repository at this point in the history
* 24638 - fix: incorrect name in amalgamation application

* 24638 - chore: add additional translations for company types.
  • Loading branch information
hfekete authored Nov 29, 2024
1 parent 483de66 commit f6f566d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/interfaces/business-i.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export interface BusinessWarningI {
data?: any // optional extra properties (eg, amalgamationDate)
}

/** The Business object from the Legal API. */
// comments come from business-filings-ui project ApiBusinessIF interface
export interface BusinessI extends SlimBusinessI {
adminFreeze: boolean
Expand Down
3 changes: 3 additions & 0 deletions src/lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,15 @@
"registrationNum": "Registration Number",
"legalTypes": {
"CC": "BC Community Contribution Company",
"CCC": "BC Community Contribution Company",
"BEN": "BC Benefit Company",
"CBEN": "BC Benefit Company",
"BC": "BC Limited Company",
"CP": "BC Cooperative Association",
"SP": "BC Sole Proprietorship",
"GP": "BC General Partnership",
"ULC": "BC Unlimited Liability Company",
"CUL": "BC Unlimited Liability Company",
"C": "BC Limited Company",
"undefined": "N/A"
}
Expand Down
4 changes: 3 additions & 1 deletion src/stores/businessBootstrap.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const useBcrosBusinessBootstrap = defineStore('bcros/businessBootstrap',
const bootstrapLegalType = computed(() => bootstrapFiling.value?.filing.business.legalType)
const bootstrapFilingType = computed(() => bootstrapFiling.value?.filing.header.name)
const bootstrapFilingStatus = computed(() => bootstrapFiling.value?.filing.header.status)

const bootstrapNr = computed(() => bootstrapFiling.value?.filing[bootstrapFilingType.value]?.nameRequest)
const bootstrapNrNumber = computed(() =>
bootstrapFiling.value?.filing[bootstrapFilingType.value]?.nameRequest.nrNumber)
const bootstrapFilingDisplayName = computed(() => {
Expand Down Expand Up @@ -101,6 +101,8 @@ export const useBcrosBusinessBootstrap = defineStore('bcros/businessBootstrap',
if (bootstrapNrNumber.value) {
// get approved name from the linked name request
return linkedNr.value?.names.find(val => val.state === NameRequestStateE.APPROVED)?.name
} else if (bootstrapNr?.value?.legalName) {
return bootstrapNr.value.legalName
} else {
// return the numbered name description
if (bootstrapFilingType.value === FilingTypes.AMALGAMATION_APPLICATION) {
Expand Down

0 comments on commit f6f566d

Please sign in to comment.