Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21802 - Add details call and list. #21

Merged
merged 4 commits into from
Aug 2, 2024
Merged

21802 - Add details call and list. #21

merged 4 commits into from
Aug 2, 2024

Conversation

hfekete
Copy link
Collaborator

@hfekete hfekete commented Aug 2, 2024

*Issue:21802 *bcgov/entity#21802

Description of changes:

  • add details button
  • comments visible
  • prepared code for putting in popup
  • tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@hfekete hfekete self-assigned this Aug 2, 2024
@hfekete
Copy link
Collaborator Author

hfekete commented Aug 2, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-21-w2akg042.web.app

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this is looking really good, just needs CI fix and its good to go I think

{{ isShowBody ? $t('label.filing.detail') : $t('label.filing.detail') }}
({{ filing.commentsCount }})</span>
</UButton>
<diV>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capital 'V' here?

@hfekete
Copy link
Collaborator Author

hfekete commented Aug 2, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-21-w2akg042.web.app

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hfekete hfekete merged commit de00764 into bcgov:main Aug 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants