-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21802 - Add details call and list. #21
Conversation
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-21-w2akg042.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey this is looking really good, just needs CI fix and its good to go I think
{{ isShowBody ? $t('label.filing.detail') : $t('label.filing.detail') }} | ||
({{ filing.commentsCount }})</span> | ||
</UButton> | ||
<diV> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
capital 'V' here?
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-21-w2akg042.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
*Issue:21802 *bcgov/entity#21802
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).