Fix: 1745 milestone values persist #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sepehr-Sobhani
changed the title
BCerki
reviewed
Jul 25, 2023
There was a problem hiding this comment.
Nice work!
A couple things:
- This PR removes the calculated values from the payments table, but I wonder if it should remove the payment record entirely?
- I'm seeing a funky diff for holdback:
This happened when I created a new project, created a General Milestone, and filled out everything. Then in my revision I changed the type to a Reporting Milestone
schema/test/unit/mutations/update_milestone_form_change_test.sql
Outdated
Show resolved
Hide resolved
Sepehr-Sobhani
force-pushed
the
1745-milestone-values-persist
branch
2 times, most recently
from
fb61175
to
725f58d
Compare
BCerki
reviewed
Jul 28, 2023
There was a problem hiding this comment.
Nice work!
I found another redundant arrow that I added to your bug card: https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/gh/bcgov/cas-cif/1822
schema/test/unit/functions/handle_milestone_form_change_commit_test.sql
Outdated
Show resolved
Hide resolved
schema/test/unit/functions/handle_milestone_form_change_commit_test.sql
Outdated
Show resolved
Hide resolved
schema/test/unit/functions/handle_milestone_form_change_commit_test.sql
Outdated
Show resolved
Hide resolved
…igible for expenses
…e is not eligible for expenses
… between non-expense and expense types
Sepehr-Sobhani
force-pushed
the
1745-milestone-values-persist
branch
from
7d441a7
to
7b5a23b
Compare
BCerki
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZH CARD 1745